-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Add type annotations to mobject/svg/brace.py
and default to label_constructor=Text
in BraceText
#4309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add type annotations to mobject/svg/brace.py
and default to label_constructor=Text
in BraceText
#4309
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
8e25ad7
Added type annotations to mobject/svg/brace.py
henrikmidtiby f2e3d04
Do not overwrite the __all__ variable defined earlier in the file.
henrikmidtiby d65a1af
Implemented suggestions from chopan50
henrikmidtiby 6068728
Code cleanup.
henrikmidtiby 73f2de2
Implemented suggestion from chopan50
henrikmidtiby f576522
Another suggestion from chopan50
henrikmidtiby 195aaa0
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 0ad09db
Ignore single type error.
henrikmidtiby 05602fe
Merge branch 'main' into TypingBrace
chopan050 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.