Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made tests for surrounding rectangle and stream lines pass #4136

Draft
wants to merge 2 commits into
base: experimental
Choose a base branch
from

Conversation

henrikmidtiby
Copy link
Contributor

I have identified some tests that I would like to fix in experimental. The tests can be evaluatated by this command.

pytest tests/module/mobject/types/vectorized_mobject/test_stroke.py

Now I have tried to make the tests pass, by changes like

  • changing base class from VMobject to OpenGLVMobject
  • fill_opacity -> get_fill_opacity()

Is this a suitable approach?

Further Information and Comments

To make the commit I had to ignore all mypy errors. Is that the preferred approach?

Reviewer Checklist

  • The PR title is descriptive enough for the changelog, and the PR is labeled correctly
  • If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
  • If applicable: newly added functions and classes are tested

tests/module/mobject/geometry/test_unit_geometry.py::test_BackgroundRectangle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant