Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop ignoring manim.plugins errors in mypy.ini #4006

Merged
merged 1 commit into from
Nov 10, 2024
Merged

Stop ignoring manim.plugins errors in mypy.ini #4006

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions manim/plugins/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
from __future__ import annotations

from manim import config, logger

from .plugins_flags import get_plugins, list_plugins
from manim._config import config, logger
from manim.plugins.plugins_flags import get_plugins, list_plugins

__all__ = [
"get_plugins",
Expand Down
6 changes: 3 additions & 3 deletions manim/plugins/plugins_flags.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
else:
from importlib.metadata import entry_points

from manim import console
from manim._config import console

__all__ = ["list_plugins"]

Expand All @@ -27,5 +27,5 @@ def list_plugins() -> None:
console.print("[green bold]Plugins:[/green bold]", justify="left")

plugins = get_plugins()
for plugin in plugins:
console.print(f" • {plugin}")
for plugin_name in plugins:
console.print(f" • {plugin_name}")
3 changes: 0 additions & 3 deletions mypy.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,9 +73,6 @@ ignore_errors = True
[mypy-manim.mobject.geometry.*]
ignore_errors = False

[mypy-manim.plugins.*]
ignore_errors = True

[mypy-manim.renderer.*]
ignore_errors = True

Expand Down
Loading