-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Type annotation work in manim/mobject/geometry/ #3961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
JasonGrace2282
merged 44 commits into
ManimCommunity:main
from
henrikmidtiby:type_annotation_work
Oct 27, 2024
Merged
Changes from 19 commits
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
35597d5
Removed type annotation errors
henrikmidtiby cd73909
Removed type annotation errors
henrikmidtiby 1ba82f7
Removed typing errors in mobject/geometry/arc.py
henrikmidtiby 3b38bba
Removed typing errors in mobject/geometry/shape_matchers.py
henrikmidtiby b6f8e38
Added type annotations fo mobject/types/image_mobject.py and a few ot…
henrikmidtiby 5bf79dc
Avoid overwriting the invert method of the superclass
henrikmidtiby 612068d
Adding type annotations to types/point_cloud_mobject.py
henrikmidtiby 774c136
Fixing issues revealed by type annotations in types/point_cloud_mobje…
henrikmidtiby be3938d
Fix issue in the CI step related to the Camera class.
henrikmidtiby 5be34e3
Removed type errors by replacing Point3D with InternalPoint3D
henrikmidtiby bbfb247
Adding type annotations to geometry/line.py
henrikmidtiby d294e6f
Fix issues identified by type annotations.
henrikmidtiby 00a0b1f
Work on type annotations in geometry/polygram.py
henrikmidtiby 257c023
Ignore type errors related to super and sub class in line.py and shap…
henrikmidtiby 6b88833
Remove return value from the internal method _account_for_buff
henrikmidtiby 16716a4
Dealing with some issues and ignoring others identified by type checking
henrikmidtiby efe49b7
Ignored a number of type issues related to float and floating[Any].
henrikmidtiby 68a3d66
Help mypy to determine types.
henrikmidtiby 80226e2
Fix issues identified by mypy
henrikmidtiby 0018f8d
Change example in docs for _convert_2d_to_3d_array
henrikmidtiby 56d2a94
Change example in docs for _convert_2d_to_3d_array to make the doctes…
henrikmidtiby 66d2cea
More work on addressing typing issues.
henrikmidtiby 33da68d
Reverting two changes that triggers an error in the automatic testing.
henrikmidtiby e498903
Further work on type hinting.
henrikmidtiby e18a644
Added comment to why these mypy errors can be ignored
henrikmidtiby 80ae857
Avoid forwarding positional arguments from Arrow to Line in the const…
henrikmidtiby d477c9a
Activate mypy check of mobject.geometry.*
henrikmidtiby a14b99a
Revert "Avoid forwarding positional arguments from Arrow to Line in t…
henrikmidtiby 07bbe3f
Removed several type ignore statements and addressed comments from Ja…
henrikmidtiby 46bbcba
Revert "Activate mypy check of mobject.geometry.*"
henrikmidtiby 61a9168
Revert "Removed several type ignore statements and addressed comments…
henrikmidtiby 50169c2
Update manim/mobject/geometry/arc.py
henrikmidtiby daa6a08
Remove redundant type annotations.
henrikmidtiby 7647209
Change np.array to np.asarray
henrikmidtiby 581c72a
Avoid type annotations in comments.
henrikmidtiby ed422ce
Change from np.array to np.asarray
henrikmidtiby 601072d
Switch to StrPath for typing in two locations.
henrikmidtiby ecd9357
Change the type annotation Any to something more specific.
henrikmidtiby 3e30555
Change InternalPoint3D to Point3D for an argument to the Polygram con…
henrikmidtiby 9a92bf5
Remove unneccessary noqa
JasonGrace2282 5bfc25e
Merge branch 'main' of https://github.com/ManimCommunity/manim into t…
JasonGrace2282 53ba462
enable mypy type-checking on manim.mobject.geometry.*
JasonGrace2282 d288979
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 01e566a
fix mypy ci
JasonGrace2282 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.