Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type hints to animation #3457

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Add mypy to dependencies

17efceb
Select commit
Loading
Failed to load commit list.
Draft

Add type hints to animation #3457

Add mypy to dependencies
17efceb
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / CodeQL succeeded Feb 13, 2024 in 5s

4 new alerts

New alerts in code changed by this pull request

  • 3 warnings
  • 1 note

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 153 in manim/animation/animation.py

See this annotation in the file changed.

Code scanning / CodeQL

Overwriting attribute in super-class or sub-class Warning

Assignment overwrites attribute run_time, which was previously defined in subclass
Flash
Loading
.
Assignment overwrites attribute run_time, which was previously defined in subclass
TransformAnimations
Loading
.
Assignment overwrites attribute run_time, which was previously defined in subclass
TransformAnimations
Loading
.

Check warning on line 154 in manim/animation/animation.py

See this annotation in the file changed.

Code scanning / CodeQL

Overwriting attribute in super-class or sub-class Warning

Assignment overwrites attribute rate_func, which was previously defined in subclass
AnimationGroup
Loading
.
Assignment overwrites attribute rate_func, which was previously defined in subclass
ChangeSpeed
Loading
.

Check warning on line 157 in manim/animation/animation.py

See this annotation in the file changed.

Code scanning / CodeQL

Overwriting attribute in super-class or sub-class Warning

Assignment overwrites attribute remover, which was previously defined in subclass
ShowPassingFlashWithThinningStrokeWidth
Loading
.

Check notice on line 579 in manim/typing.py

See this annotation in the file changed.

Code scanning / CodeQL

Unused global variable Note

The global variable 'RateFunc' is not used.