-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue where test leaves a dirty git tree #23231
Conversation
In 195a04f, a test was removed that had created a local repo in the git_repos dir, but the cleanup from the after block was not removed. This cleanup removes the .gitkeep file, which causes a dirty tree.
0a0485b
to
a4da531
Compare
@agrare I noticed you had opened #22960, but it was WIP. I think this does the same thing? #22960 sort of does multiple things...this change, which causes a dirty repository, but then also the git_repository_spec leaves behind dirty directories. I only did the former here. I'm good with merging #22960 if you unWIP it |
Checked commit Fryguy@a4da531 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
Hm it was a while ago but I thought I had to do more than just delete this in order to not leave lockfiles around after the tests ran, let me double check... |
Specifically for the dirty tree from embedded_ansible_spec, you only this need change. If you want to fully cleanup the git_repos dir after the git_repository_spec you need the other change. |
Yeah after running these tests I still have
I suppose those aren't hurting anything other than cluttering up the locks dir, we can merge this then I'll rebase my PR and fix just the locks being left on the filesystem. |
In 195a04f, a test was removed that had created a local repo in the git_repos dir, but the cleanup from the after block was not removed. This cleanup removes the .gitkeep file, which causes a dirty tree.
@kbrock Please review.