Fix aggregate_cpu/memory utilization methods for Containers #22951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default aggregate_cpu/memory utilization methods use Hosts not ContainerNodes which doesn't work for ContainerManagers.
|
Checked commit agrare@bfa1249 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
GilbertCherrie
approved these changes
Mar 20, 2024
kbrock
approved these changes
Mar 20, 2024
|
ping @Fryguy |
|
Backported to |
Fryguy
added a commit
that referenced
this pull request
Mar 28, 2024
…_cpu_memory_methods Fix aggregate_cpu/memory utilization methods for Containers (cherry picked from commit 5a25f61)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default aggregate_cpu/memory utilization methods use Hosts not ContainerNodes which doesn't work for ContainerManagers.
These are the methods being used for the table, https://github.com/ManageIQ/manageiq/blob/master/app/models/mixins/aggregation_mixin.rb#L5 which use
:host_hardwareswhich won't be valid for ContainerManagers.Before:
After:
Follow-up,
what do other providers without Hosts do (thinking PhysicalInfraManagers that have PhysicalServers)It seems like Infra and Container are the only two manager types that show aggregate cpu/memory on the UI.