Update provider generator supports :create/DDFv2 #22950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the provider generator to include `supports :create` since that is now what is used to build the list of providers that can be added, as well as update the default params_for_create for DDF v2.
agrare
commented
Mar 19, 2024
Comment on lines
-17
to
-21
| { | ||
| :component => "text-field", | ||
| :name => "provider_region", | ||
| :label => _("Provider Region"), | ||
| }, |
There was a problem hiding this comment.
NOTE provider_region doesn't make sense for a lot of the supported provider types and the "writing_a_new_provider" guide covers adding a proper provider regions dropdown not a simple text field.
|
Checked commit agrare@ede60b8 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
Fryguy
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the provider generator to include
supports :createsince that is now what is used to build the list of providers that can be added, as well as update the default params_for_create for DDF v2 similar to ManageIQ/manageiq-providers-vmware#612