Remove return value from sync_workers and friends

ManageIQ · Mar 13, 2024 · 7a3131a · 7a3131a
1 parent a44f18c
commit 7a3131a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 12 deletions.
diff --git a/app/models/miq_server/worker_management/kubernetes.rb b/app/models/miq_server/worker_management/kubernetes.rb
@@ -33,16 +33,11 @@ def sync_starting_workers
   end
 
   def sync_stopping_workers
-    stopping = MiqWorker.find_all_stopping.to_a
-
-    stopping.reject { |w| w.class.rails_worker? }.each do |worker|
+    MiqWorker.find_all_stopping.reject { |w| w.class.rails_worker? }.each do |worker|
       next if get_pod(worker[:system_uid]).present?
 
       worker.update!(:status => MiqWorker::STATUS_STOPPED)
-      stopping.delete(worker)
     end
-
-    stopping
   end
 
   def enough_resource_to_start_worker?(_worker_class)

diff --git a/app/models/miq_server/worker_management/systemd.rb b/app/models/miq_server/worker_management/systemd.rb
@@ -19,20 +19,15 @@ def sync_starting_workers
   end
 
   def sync_stopping_workers
-    stopping = MiqWorker.find_all_stopping.to_a
-
     sync_from_system
 
-    stopping.reject { |w| w.class.rails_worker? }.each do |worker|
+    MiqWorker.find_all_stopping.reject { |w| w.class.rails_worker? }.each do |worker|
       # If the worker record is "stopping" and the systemd unit is gone then the
       # worker has successfully exited.
       next if miq_services_by_unit[worker[:system_uid]].present?
 
       worker.update!(:status => MiqWorker::STATUS_STOPPED)
-      stopping.delete(worker)
     end
-
-    stopping
   end
 
   def cleanup_failed_workers