Openshift volume Attach/Detach

[chitra607]

No description provided.

[miq-bot]

Checked commits chitra607/manageiq-ui-classic@9297892~...d1f700d with ruby 3.1.7, rubocop 1.56.3, haml-lint 0.64.0, and yamllint
9 files checked, 10 offenses detected

app/controllers/vm_common.rb

• ❗ - Line 39, Col 3 - Style/Alias - Use alias instead of alias_method in a module body.
• ❗ - Line 52, Col 3 - Style/Alias - Use alias instead of alias_method in a module body.

app/controllers/vm_infra_controller.rb

• ❗ - Line 44, Col 1 - Layout/EmptyLinesAroundExceptionHandlingKeywords - Extra empty line detected before the rescue.

app/helpers/application_helper/button/vm_attach_volume.rb

• ❗ - Line 2, Col 17 - Layout/TrailingWhitespace - Trailing whitespace detected.
• ❗ - Line 4, Col 5 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.
• ❗ - Line 6, Col 4 - Layout/TrailingEmptyLines - Final newline missing.

app/helpers/application_helper/button/vm_detach_volume.rb

• ❗ - Line 2, Col 17 - Layout/TrailingWhitespace - Trailing whitespace detected.
• ❗ - Line 4, Col 5 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.

app/views/vm_common/_add_volume.html.haml

• 💣 💥 🔥 🚒 - Line 0 - app/views/vm_common/_add_volume.html.haml - Invalid filter name ":recordid => @record.id.to_s,".

app/views/vm_common/_remove_volume.html.haml

• 💣 💥 🔥 🚒 - Line 0 - app/views/vm_common/_remove_volume.html.haml - Invalid filter name ":recordid => @record.id.to_s,".

[agrare]

@chitra607 I think we want to use VM Reconfigure for this so it would fit in to existing UI / API flows and not need anything extra here

[agrare]

NOTE storage_classes isn't something that we currently have. We would need to collect them in inventory refresh as part of the provider and persist them in the database for this to work. We do currently have a StorageProfile model which we could use to store these without having to create a new table/model.

[chitra607]

Thanks @agrare. Just to clarify, storage_classes here is a function I added that fetches the list directly from the OpenShift/KubeVirt API at runtime, it is not a table/model. Would it make sense to use the existing StorageProfile model to persist storage classes list in OpenShift/KubeVirt as you suggested?

[agrare]

Yeah that's not going to work for a couple of reasons, first this is generic VM code so we can't have provider specific methods in here, also since this is running from the UI role we can't run anything that would hit the live provider since that can only be guaranteed to be accessed via ems_operations role in the proper zone.

StorageProfiles sound like they could be a good match, what data do you need for them other than uid/name?

[chitra607]

In the infrastructure VM volume attach workflow we have two options:

• Select an existing PVC
• Create a new PVC and attach it to the VM
  For the create new PVC case, I need to list the available OpenShift storage class names so the user can choose one (since storageClassName is required when creating a PVC)