[MORPHY] Rexml rails version #777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kbrock
commented
Jan 9, 2025
kbrock
commented
- CVE-2024-49761 rexml ( /via style)
- CVE-2023-38037 active-support
kbrock
added
dependencies
Mend: dependency security vulnerability
Fryguy
reviewed
Jan 9, 2025
manageiq-schema.gemspec
Outdated
| @@ -25,10 +25,10 @@ Gem::Specification.new do |spec| | |||
| spec.add_dependency "more_core_extensions", ">= 3.5", "< 5" | |||
| spec.add_dependency "pg" | |||
| spec.add_dependency "pg-pglogical", "~> 2.1.1" | |||
| spec.add_dependency "rails", "~>6.0.0" | |||
| spec.add_dependency "rails", "~> 6.0.0", "> 6.0.6.1" | |||
There was a problem hiding this comment.
You missed the = - this will fail without it.
Suggested change
| spec.add_dependency "rails", "~> 6.0.0", "> 6.0.6.1" | |
| spec.add_dependency "rails", "~> 6.0.6", ">= 6.0.6.1" |
Fryguy
reviewed
Jan 9, 2025
|
|
||
| spec.add_development_dependency "manageiq-style", ">= 1.5.2" | ||
| spec.add_development_dependency "manageiq-style", ">= 1.5.3" |
There was a problem hiding this comment.
To keep it consistent, can you also make this change on master?
- CVE-2024-49761 rexml ( /via style) - CVE-2023-38037 active-support
kbrock
force-pushed
the
rexml-rails-version
branch
from
860d364 to
eec3d71
Compare
|
update:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.