Add Node affinity #1003
Add Node affinity #1003
Conversation
In my opinion since its technically just a refactor I would say to keep it in |
| - key: kubernetes.io/arch | ||
| operator: In | ||
| values: | ||
| - amd64 |
There was a problem hiding this comment.
Do we also want s390x and ppc64le like in downstream?
There was a problem hiding this comment.
We don't build those targets in upstream, so no? I'm not sure how this will work in downstream though if we have additional arches.
There was a problem hiding this comment.
In downstream we have a separate setNodeAffinity function that adds the other arches to the Kafka CR
There was a problem hiding this comment.
Do we also want s390x and ppc64le like in downstream?
No, we only build x86_64 upstream
I'm not sure how this will work in downstream though if we have additional arches.
We don't use this file downstream. The downstream operator will deploy the manageiq operator with the correct values.
|
| func OperatorNodeAffinityArchValues(deployment *appsv1.Deployment, client client.Client) []string { | ||
| podName := os.Getenv("POD_NAME") | ||
| pod := FindPodByName(client, deployment.ObjectMeta.Namespace, podName) | ||
| values := []string{"amd64"} |
There was a problem hiding this comment.
I added a commit to default to amd64
This will discover the node affinities applied to the operator and apply the same affinities to httpd, postgres, memcached and the orchestrator. I'll be opening a PR shortly that does the same tihng inside the orchestrator for the deployments that it creates. |
|
@bdunne Can we merge this now or do we have to wait for the core orchestrator change? Second question. If we run on an older OpenShift, will these nodeAffinities cause issues, or are they just ignored on older OpenShifts |
|
This can be merged before the orchestrator changes. My test cluster is 4.13.4 and it's working fine there. I can't find when |
|
Skipping backport to |
|
Skipping backport to |
For OpenShift 4.14 support
Part of #988