Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix local spec failures on ruby 3.1 #247

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Conversation

bdunne
Copy link
Member

@bdunne bdunne commented Apr 30, 2024

Failures:

  1) LinuxAdmin::EtcIssue should find upper phrase in file
     Failure/Error: expect(subject).to include("phrase")

     NameError:
       uninitialized constant RSpec::Support::Differ
     # ./spec/etc_issue_spec.rb:30:in `block (2 levels) in <top (required)>'

  2) LinuxAdmin::EtcIssue should not find phrase when the file has a different phrase
     Failure/Error: expect(subject).not_to include("phrase")

     NameError:
       uninitialized constant RSpec::Support::Differ
     # ./spec/etc_issue_spec.rb:20:in `block (2 levels) in <top (required)>'

  3) LinuxAdmin::EtcIssue should find phrase when searching with upper
     Failure/Error: expect(subject).to include("PHRASE")

     NameError:
       uninitialized constant RSpec::Support::Differ
     # ./spec/etc_issue_spec.rb:35:in `block (2 levels) in <top (required)>'

  4) LinuxAdmin::EtcIssue should not find the phrase when the file is missing
     Failure/Error: expect(subject).not_to include("phrase")

     NameError:
       uninitialized constant RSpec::Support::Differ
     # ./spec/etc_issue_spec.rb:10:in `block (2 levels) in <top (required)>'

  5) LinuxAdmin::EtcIssue should not find phrase when the file is empty
     Failure/Error: expect(subject).not_to include("phrase")

     NameError:
       uninitialized constant RSpec::Support::Differ
     # ./spec/etc_issue_spec.rb:15:in `block (2 levels) in <top (required)>'

  6) LinuxAdmin::EtcIssue should find phrase in same case
     Failure/Error: expect(subject).to include("phrase")

     NameError:
       uninitialized constant RSpec::Support::Differ
     # ./spec/etc_issue_spec.rb:25:in `block (2 levels) in <top (required)>'

  7) LinuxAdmin::SubscriptionManager#register with username and password with server_url
     Failure/Error: host = server.start_with?("http") ? ::URI.parse(server).host : server

     NameError:
       uninitialized constant URI
     # ./lib/linux_admin/registration_system.rb:50:in `install_server_certificate'
     # ./lib/linux_admin/registration_system/subscription_manager.rb:45:in `register'
     # ./spec/subscription_manager_spec.rb:79:in `block (4 levels) in <top (required)>'

Finished in 0.30563 seconds (files took 0.30077 seconds to load) 316 examples, 7 failures

Failed examples:

rspec ./spec/etc_issue_spec.rb:28 # LinuxAdmin::EtcIssue should find upper phrase in file rspec ./spec/etc_issue_spec.rb:18 # LinuxAdmin::EtcIssue should not find phrase when the file has a different phrase rspec ./spec/etc_issue_spec.rb:33 # LinuxAdmin::EtcIssue should find phrase when searching with upper rspec ./spec/etc_issue_spec.rb:8 # LinuxAdmin::EtcIssue should not find the phrase when the file is missing rspec ./spec/etc_issue_spec.rb:13 # LinuxAdmin::EtcIssue should not find phrase when the file is empty rspec ./spec/etc_issue_spec.rb:23 # LinuxAdmin::EtcIssue should find phrase in same case rspec ./spec/subscription_manager_spec.rb:72 # LinuxAdmin::SubscriptionManager#register with username and password with server_url

Randomized with seed 36320

Failures:

  1) LinuxAdmin::EtcIssue should find upper phrase in file
     Failure/Error: expect(subject).to include("phrase")

     NameError:
       uninitialized constant RSpec::Support::Differ
     # ./spec/etc_issue_spec.rb:30:in `block (2 levels) in <top (required)>'

  2) LinuxAdmin::EtcIssue should not find phrase when the file has a different phrase
     Failure/Error: expect(subject).not_to include("phrase")

     NameError:
       uninitialized constant RSpec::Support::Differ
     # ./spec/etc_issue_spec.rb:20:in `block (2 levels) in <top (required)>'

  3) LinuxAdmin::EtcIssue should find phrase when searching with upper
     Failure/Error: expect(subject).to include("PHRASE")

     NameError:
       uninitialized constant RSpec::Support::Differ
     # ./spec/etc_issue_spec.rb:35:in `block (2 levels) in <top (required)>'

  4) LinuxAdmin::EtcIssue should not find the phrase when the file is missing
     Failure/Error: expect(subject).not_to include("phrase")

     NameError:
       uninitialized constant RSpec::Support::Differ
     # ./spec/etc_issue_spec.rb:10:in `block (2 levels) in <top (required)>'

  5) LinuxAdmin::EtcIssue should not find phrase when the file is empty
     Failure/Error: expect(subject).not_to include("phrase")

     NameError:
       uninitialized constant RSpec::Support::Differ
     # ./spec/etc_issue_spec.rb:15:in `block (2 levels) in <top (required)>'

  6) LinuxAdmin::EtcIssue should find phrase in same case
     Failure/Error: expect(subject).to include("phrase")

     NameError:
       uninitialized constant RSpec::Support::Differ
     # ./spec/etc_issue_spec.rb:25:in `block (2 levels) in <top (required)>'

  7) LinuxAdmin::SubscriptionManager#register with username and password with server_url
     Failure/Error: host = server.start_with?("http") ? ::URI.parse(server).host : server

     NameError:
       uninitialized constant URI
     # ./lib/linux_admin/registration_system.rb:50:in `install_server_certificate'
     # ./lib/linux_admin/registration_system/subscription_manager.rb:45:in `register'
     # ./spec/subscription_manager_spec.rb:79:in `block (4 levels) in <top (required)>'

Finished in 0.30563 seconds (files took 0.30077 seconds to load)
316 examples, 7 failures

Failed examples:

rspec ./spec/etc_issue_spec.rb:28 # LinuxAdmin::EtcIssue should find upper phrase in file
rspec ./spec/etc_issue_spec.rb:18 # LinuxAdmin::EtcIssue should not find phrase when the file has a different phrase
rspec ./spec/etc_issue_spec.rb:33 # LinuxAdmin::EtcIssue should find phrase when searching with upper
rspec ./spec/etc_issue_spec.rb:8 # LinuxAdmin::EtcIssue should not find the phrase when the file is missing
rspec ./spec/etc_issue_spec.rb:13 # LinuxAdmin::EtcIssue should not find phrase when the file is empty
rspec ./spec/etc_issue_spec.rb:23 # LinuxAdmin::EtcIssue should find phrase in same case
rspec ./spec/subscription_manager_spec.rb:72 # LinuxAdmin::SubscriptionManager#register with username and password with server_url

Randomized with seed 36320
@miq-bot
Copy link
Member

miq-bot commented Apr 30, 2024

Checked commit bdunne@0e9fa4d with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
2 files checked, 0 offenses detected
Everything looks fine. 👍

@agrare agrare merged commit db87119 into ManageIQ:master Apr 30, 2024
5 checks passed
@bdunne bdunne deleted the fix_local_tests branch April 30, 2024 21:49
bdunne added a commit that referenced this pull request Apr 30, 2024
Breaking Changes:
- Bump required_ruby_version to 2.6 & Bump net-ssh for OpenSSL 3.0 support #244

Changed:
- Bump ed25519 upper version limit to 2.0 #246
- Bump awesome_spawn minimum to 1.6 #240
- Change redirects to be portable #235
- use PATH to find executable commands #233

Test:
- Fix local spec failures on ruby 3.1 #247
- Update paambaati/codeclimate-action action to v6 #245
- Add renovate.json #234
- Update codeclimate channel to the latest in manageiq-style #242
- Test with ruby 3.1 and 3.0 #241
- Fix AwesomeSpawn spec failures #238
- Update actions/checkout version to v4 #237
- Update GitHub Actions versions #236
- update specs to work with recent rspec versions #232
- Add timeout-minutes to setup-ruby job #231
- Switch to GitHub Actions #230
- Remove Hakiri #229
- Fix whitesource config files #228
- Add .whitesource configuration file #227
- Update manageiq-style #226
- drop sudo:false #222
- Switch to manageiq-style #219
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants