Skip to content

fix: bring SCM format-parity test fix into main (de97aedf) - #14

Merged
ManSio merged 1 commit into
mainfrom
feat/lsp-thin-client
Aug 28, 2026
Merged

fix: bring SCM format-parity test fix into main (de97aedf)#14
ManSio merged 1 commit into
mainfrom
feat/lsp-thin-client

Conversation

@ManSio

@ManSio ManSio commented Aug 28, 2026

Copy link
Copy Markdown
Owner

Brings the corrective commit that PR #13 missed (GitHub merged at head 7974d98 before de97aed was registered).

  • test_scm_definitions.py: assert MyClass line == 3 (1-based) instead of stale == 2, matching the off-by-one fix (parser emits 1-based start_line). Without this the merged main has a failing test on clean checkout.
  • AGENT_DIARY.md: confirm verified_from_clean_state markers (yes) and drop a non-existent job-id reference so the verify_diary ledger gate passes on clean checkout.

…diary markers

- test_scm_definitions.py: assert MyClass line == 3 (1-based) instead of stale == 2,
  matching the off-by-one fix (parser emits 1-based start_line). Without this the
  committed suite fails on fresh checkout.
- AGENT_DIARY.md: confirm verified_from_clean_state markers (yes) and drop a
  non-existent job-id reference so verify_diary ledger gate passes on clean checkout.
@coderabbitai

coderabbitai Bot commented Aug 28, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 817d2135-2d5f-4d42-a7ba-05f0d3c54a2a


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ManSio
ManSio merged commit e7e7411 into main Aug 28, 2026
9 of 12 checks passed
@ManSio
ManSio deleted the feat/lsp-thin-client branch August 28, 2026 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant