fix(verify): real-boundary fixes — CRLF patch, tree-sitter Tree/bytes, stderr - #11
Merged
Conversation
…, stderr - change_preview._run: surface stderr on failure (was DEVNULL -> empty diagnostics; 'patch --check failed:' had no message). - change_preview: write patch with newline='\n' — Path.write_text CRLF-translated the patch on Windows, git apply --check failed (bash-repro with LF patch passed). - language_imports._iter_nodes: real tree-sitter returns a TREE (.root_node holds children) — fake-tree tests missed it, real parse silently returned []. - language_imports: decode bytes node.text (tree-sitter gives bytes -> 'b\'ast\''); skip import_list/aliased_import subtrees (names of imports are not modules). - Guard: test_real_treesitter_tree_shape (Tree-shape regression). Live accuracy vs ground truth: ast/re/pathlib/typing correct; __future__ miss + import-symbol noise documented as best-effort limits.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Три реальных бага, вскрытых ЖИВОЙ верификацией (fake/unit-тесты были зелёными):
".
Плюс: _run теперь показывает stderr при провале (было DEVNULL — пустая диагностика).
Guard: 16 тестов (12 language_imports + 4 change_preview); live-точность против ground-truth: ast/re/pathlib/typing верны, future miss + символы-шум — задокументированные best-effort границы.