Merge pull request #6 from andresmoschini/fix

andresmoschini · web-flow · commit bc549eeb8371 · 2016-12-02T11:50:30.000-03:00
Fix
diff --git a/appveyor.yml b/appveyor.yml
@@ -1,6 +1,6 @@
 os: Visual Studio 2015
 
-version: 1.0.2-alpha-{build}
+version: 1.0.3-alpha-{build}
 
 nuget:
   account_feed: true
diff --git a/global.json b/global.json
@@ -1,8 +1,6 @@
 ﻿{
   "projects": [ "src", "test" ],
   "sdk": {
-    "version": "1.0.0-preview2-003131",
-    "runtime": "clr",
-    "architecture": "x86"
+    "version": "1.0.0-preview2-003131"
   }
 }
diff --git a/src/MakingSense.AspNetCore.Authentication.SimpleToken/SimpleTokenAppBuilderExtensions.cs b/src/MakingSense.AspNetCore.Authentication.SimpleToken/SimpleTokenAppBuilderExtensions.cs
@@ -38,6 +38,15 @@ public static IApplicationBuilder UseSimpleTokenAuthentication(this IApplication
 
 			if (options.SecurityTokenValidatorsFactory == null)
 			{
+				// TODO: fix it because it is using app services, and it should use scope services,
+				// a work around could be:
+				// ```
+				// SecurityTokenValidatorsFactory = () =>
+				// {
+				//     var context = app.ApplicationServices.GetService<IHttpContextAccessor>().HttpContext;
+				//     return context.RequestServices.GetServices<ISecurityTokenValidator>();
+				// }
+				// ```
 				options.SecurityTokenValidatorsFactory = () => app.ApplicationServices.GetServices<ISecurityTokenValidator>();
 			}
 
diff --git a/src/MakingSense.AspNetCore.Authentication.SimpleToken/project.json b/src/MakingSense.AspNetCore.Authentication.SimpleToken/project.json
@@ -1,5 +1,5 @@
 ﻿{
-  "version": "1.0.2-alpha-*",
+  "version": "1.0.3-alpha-*",
   "description": "MakingSense.AspNetCore.Authentication.SimpleToken Class Library",
   "authors": [ "MakingSense" ],
   "packOptions": {
@@ -12,7 +12,7 @@
     "licenseUrl": "http://www.gnu.org/licenses/lgpl.html"
   },
   "dependencies": {
-    "MakingSense.AspNetCore.Abstractions": "1.0.2-alpha-*",
+    "MakingSense.AspNetCore.Abstractions": "1.0.3-*",
     "Microsoft.AspNetCore.Authentication": "1.0.0",
     "Microsoft.IdentityModel.Tokens": "5.0.0",
     "Newtonsoft.Json": "9.0.1"

Original file line number	Diff line number	Diff line change
`@@ -1,8 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"projects": [ "src", "test" ],`
`3`	`3`	`"sdk": {`
`4`		`- "version": "1.0.0-preview2-003131",`
`5`		`- "runtime": "clr",`
`6`		`- "architecture": "x86"`
	`4`	`+ "version": "1.0.0-preview2-003131"`
`7`	`5`	`}`
`8`	`6`	`}`
Original file line number	Diff line number	Diff line change
`@@ -38,6 +38,15 @@ public static IApplicationBuilder UseSimpleTokenAuthentication(this IApplication`
`38`	`38`
`39`	`39`	`if (options.SecurityTokenValidatorsFactory == null)`
`40`	`40`	`{`
	`41`	`+ // TODO: fix it because it is using app services, and it should use scope services,`
	`42`	`+ // a work around could be:`
	`43`	+ // ```
	`44`	`+ // SecurityTokenValidatorsFactory = () =>`
	`45`	`+ // {`
	`46`	`+ // var context = app.ApplicationServices.GetService<IHttpContextAccessor>().HttpContext;`
	`47`	`+ // return context.RequestServices.GetServices<ISecurityTokenValidator>();`
	`48`	`+ // }`
	`49`	+ // ```
`41`	`50`	`options.SecurityTokenValidatorsFactory = () => app.ApplicationServices.GetServices<ISecurityTokenValidator>();`
`42`	`51`	`}`
`43`	`52`