Add TODO note related to ValidatorsFactory lifetime

andresmoschini · andresmoschini · commit 485caaaa69d8 · 2016-11-09T14:35:37.000-03:00
diff --git a/src/MakingSense.AspNetCore.Authentication.SimpleToken/SimpleTokenAppBuilderExtensions.cs b/src/MakingSense.AspNetCore.Authentication.SimpleToken/SimpleTokenAppBuilderExtensions.cs
@@ -38,6 +38,15 @@ public static IApplicationBuilder UseSimpleTokenAuthentication(this IApplication
 
 			if (options.SecurityTokenValidatorsFactory == null)
 			{
+				// TODO: fix it because it is using app services, and it should use scope services,
+				// a work around could be:
+				// ```
+				// SecurityTokenValidatorsFactory = () =>
+				// {
+				//     var context = app.ApplicationServices.GetService<IHttpContextAccessor>().HttpContext;
+				//     return context.RequestServices.GetServices<ISecurityTokenValidator>();
+				// }
+				// ```
 				options.SecurityTokenValidatorsFactory = () => app.ApplicationServices.GetServices<ISecurityTokenValidator>();
 			}
 

Original file line number	Diff line number	Diff line change
`@@ -38,6 +38,15 @@ public static IApplicationBuilder UseSimpleTokenAuthentication(this IApplication`
`38`	`38`
`39`	`39`	`if (options.SecurityTokenValidatorsFactory == null)`
`40`	`40`	`{`
	`41`	`+ // TODO: fix it because it is using app services, and it should use scope services,`
	`42`	`+ // a work around could be:`
	`43`	+ // ```
	`44`	`+ // SecurityTokenValidatorsFactory = () =>`
	`45`	`+ // {`
	`46`	`+ // var context = app.ApplicationServices.GetService<IHttpContextAccessor>().HttpContext;`
	`47`	`+ // return context.RequestServices.GetServices<ISecurityTokenValidator>();`
	`48`	`+ // }`
	`49`	+ // ```
`41`	`50`	`options.SecurityTokenValidatorsFactory = () => app.ApplicationServices.GetServices<ISecurityTokenValidator>();`
`42`	`51`	`}`
`43`	`52`