bugfix 2d tile depth #128
bugfix 2d tile depth #128
Conversation
src/map.jl
Outdated
| @@ -205,7 +205,7 @@ function setup_axis!(axis::Axis, ext_target, crs) | |||
| X = ext_target.X | |||
| Y = ext_target.Y | |||
| axis.autolimitaspect = 1 | |||
| Makie.limits!(axis, (X[1], X[2]), (Y[1], Y[2])) | |||
There was a problem hiding this comment.
Ooops this is just to fix the other bug that hangs vscode, but should be removed
| @@ -126,7 +147,7 @@ function cull_plots!(m::Map) | |||
| end | |||
| end | |||
|
|
|||
| function create_tile_plot!(m::AbstractMap, tile::Tile, data) | |||
| function create_tyler_plot!(m::AbstractMap, tile::Tile, data) | |||
There was a problem hiding this comment.
Reminder to self: we need to document this name change and apply it to the GeoMakie extension + all other Tyler plot configs
There was a problem hiding this comment.
Oh is this interface? Need to make that clear.
It can be some other name but there is already create_tileplot without underscore in the interface
There was a problem hiding this comment.
I checked, and the GeoMakie extension is using create_tileplot which is different from this create_tile_plot function. Let's keep create_tyler_plot.
| end | ||
| end | ||
|
|
||
| move_z(m::AbstractMap, plot, tile::Tile, bounds::Rect3) = nothing | ||
| function move_z(m::AbstractMap, plot, tile::Tile, bounds::Rect2) |
There was a problem hiding this comment.
This should only be for ImageData - we can't be doing this with Map3d or surface, for example, or the meshscatter configs...
There was a problem hiding this comment.
I don't get what we should do differently here.
|
@rafaqz @asinghvi17 tests are passing now and preview docs are also available. Didn't test locally, so I'm not sure if it addresses all glitches. |
|
Sweet...thanks! Will play around with this and test. |
|
Ok, all examples seem to work now in the docs preview. I will merge as is. Also, tested |
This PR fixes the ice melt demo so that the simulation is seen, and various z level plots behave well like they did previously.
It splits up depth scaling into plots above and below z level, and uses
visible=false/visible=trueas well as depth so that the top layer is always at zero, and the background is either below it how hidden if it has a higher zoom.It also moves the whole plot down by 10 so none of this jiggling around affects other plots.
And reorganises code a little.