Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to template 10-05 locations #58

Merged
merged 21 commits into from
Nov 16, 2024
Merged

upgrade to template 10-05 locations #58

merged 21 commits into from
Nov 16, 2024

Conversation

behinger
Copy link
Collaborator

@behinger behinger commented Sep 18, 2024

closes #51

I upgraded the 10-20 to the superset 10-05. Be warned though, the 10-20 we provided before were taken from MNE. But MNE had a (for visualization) suboptimal default of some 10-20 spherical ("perfect") locations warped to the fsaverage brain. That is probably good for source localisation, but not good for visualization (e.g. we noticed Cz is not at 0/0).

I also made a breaking change to put enlarge = 1 instead of enlarge = 1.2 - it always gave me a bit weird results and I think 1.0 is the natural factor. I dont know why in topoplot enlarge is by default 1.2?

@behinger
Copy link
Collaborator Author

I did one shortcut I have to fix: I renamed 4 10-20 channels (T3,T4,T5,T6) to their 10-05 counterpart; but I think I should rather just repeat the channels in the dictionary after loading the data

@palday
Copy link
Collaborator

palday commented Sep 30, 2024

I did one shortcut I have to fix: I renamed 4 10-20 channels (T3,T4,T5,T6) to their 10-05 counterpart; but I think I should rather just repeat the channels in the dictionary after loading the data

Yes, we can have 'duplicates' for alternate names.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drop this file from this PR 😄

src/TopoPlots.jl Outdated Show resolved Hide resolved
@palday palday merged commit c358936 into master Nov 16, 2024
3 checks passed
@palday palday deleted the locations10_05 branch November 16, 2024 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Variety of CHANNELS_10_20 eeg_topoplot: labels need to be specified twice
2 participants