-
Notifications
You must be signed in to change notification settings - Fork 264
Citation updates #3715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Citation updates #3715
Conversation
| concatenate ( | ||
| "@misc{M2,\n", | ||
| " author = {Grayson, Daniel R. and Stillman, Michael E.},\n", | ||
| " author = {Grayson, Daniel R. and Stillman, Michael E. and The Macaulay2 Authors},\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems recursive to me, and I would almost prefer not changing it.
Also, it should probably be written as {the {M}acaulay2 authors}, but you should test that it appears correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I'm not a huge fan of it either. Specific person, specific person, very general group of people. I just seem to remember maybe that's what we agreed on in M2internals? 🤷
| -- The cite command | ||
| cite = new Command from (T -> if T === () then iCite "M2" else iCite T) | ||
|
|
||
| citeAs = method() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really like this implementation, specifically because it splits the source of user-defined information that goes into the package. e.g. if I want to change something user-defined that appears in the documentation, I want to just do locate makeDocumentTag [pkgname] to find what I need to change. Why did you not like having a user defined section in the documentation of the package?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was my first attempt, actually. It required a fair amount of coaxing to get SimpleDoc to do what I wanted (keep the indentation, don't strip the newlines, etc.) And in the end, having it defined as one of the documentation keywords felt a bit strange.
In particular, we could theoretically add citation information for any documentation node, and not just the package itself. It also made it so that we wouldn't be able to place the citation information in the main package documentation page where it seemed like it should go -- near the authors, certification info, etc. All the stuff that's provided by newPackage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean to update this before the release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll update it again at the release, yes. But the current update is to add BibTeX syntax highlighting.
I was intrigued by this Copilot review thing, but I guess it isn't going to be super useful for us yet! |
|
I just realized that, for packages, this command specifically points to the master branch. Another reason to change the branch name. (the old name will still redirect to the new one) |
|
I really like the way that citations are displaying on Paul's M2 server. I asked for the citation for my package and got both my package and the JSAG citation. I like seeing both citations on the cite call. |
|
It might be good to include version numbers in the citation for M2 (or a year). In the case there's a bug in some computation, it is possible to identify if that might affect a paper. |
|
After our discussion at M2internals this afternoon, here's what I'm thinking as far as implementing how to set the citation info for a package:
Any thoughts? |
|
You can cherry-pick the last commit of this branch, which adds a |
|
I played around with this some more (see this branch), and I'm still not a fan of putting the citation info in the documentation if we're planning on using it for
I think I'd prefer to either keep the current proposal (a new |
|
Can I give it a shot? Since I pushed for it, seems unfair to leave it to you. |
|
Please do! |
|
Since #3797 dealt with the issues of adding citation information to package docs and overriding the default citation info, all that remains in this PR is updating the authors of Macaulay2 itself. At the last M2internals meeting, we discussed "Dan, Mike, and M2 authors" v. just "M2 authors". There was a very close vote, and I forget what the result was. @antonleykin, do you remember? |
It was 4 to 5 in slight favor of "just M2 authors". |
Didn't we discuss posting a poll on Zulip? (To be clear, I voted "just M2 authors") |
|
We did, but just Anton and I voted. It was a 1-1 tie lol :) |
Did you also advertise it? |
|
Apparently not! It's under the "Citation" topic in "M2 Internals Discussions". I'll see if I can drum up some more votes by tagging "everyone". |
|
Based on the feedback, I've switched this to the "The Macaulay2 Authors" option. One potential disadvantage is that the "alpha" bibliography style gives us [The] for the citations. We could drop the "The" and then it would give us [Mac], which might be nicer. Any thoughts? |
I support dropping "The". |
|
I've played with five variations of the citation and discovered that in the
|
|
should we switch to Anton's version? |
Also add "message" field to CITATION.cff (needed for validation) [ci skip]
|
Sounds good -- I went ahead and switched to "{The Authors of} M2". Some BibTeX styles will give us "T. M2" as if M2 is a person whose first name begins with T lol. But I'm not sure if there's a perfect solution. Also, GitHub's CITATION.cff converter doesn't seem to support curly braces in the author field. But its BibTeX exporting feature already gave us different results (e.g., |
antonleykin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a split opinion on this.
At the moment, I don't think it matter hugely how Macaulay2 is cited as long as the title is the same. Perhaps it is a good idea to mention somewhere that people are free to alter the rest to their liking.
In my last three articles I used the following (moderately altered) version:
@MISC{M2,
author = {Grayson, Daniel R and Stillman, Michael E and {other Macaulay2 authors}},
title = {{Macaulay2, a software system for research in algebraic geometry}},
howpublished = {Available at \url{www.macaulay2.com}}
}
It mentions Macaulay2 three times for good measure 😄

A few updates after our discussion at M2internals yesterday:
citeand to the "Cite this repository" button here on GitHub:citeAsmethod has been added toPackageCitationsthat allows package authors to override the default output ofciteand provide their own BibTeX. (In M2internals, we'd discussed maybe a new documentation keyword or option tonewPackage, but this seemed simpler maybe?)