-
Notifications
You must be signed in to change notification settings - Fork 18
update OpenBLAS commit, use macos-15.intel #223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Wow, that's a sizeable log. Adding The relevant problem seems to be: No idea what is going on there. Perhaps the XCode version bump matters? Might be pragmatic to see if the pre-cibuildwheel-conversion code has the same issue when run on |
Yes it did. See #216 |
I think if possible, this issue may need assistance from the @ openblas maintainers to investigate. I've tried using the patch here as well as compiling with the commits included in that PR, but I'm still getting the same error. |
|
If needed, I can create a separate repository that uses GitHub Actions to reproduce this bug and simplify the current workflow, so that the OpenBLAS team can investigate it more easily. |
|
I commented on the upstream issue around |
|
Digging back through history, the pre-#211 code used a github action to set xcode==15.4, and once the image updated that action started to fail. I found a successful x86_64 build from August 17. |
|
It seems the gfortran in the macos images is not really what we need, see the discussion on #224. Even if I could get it to actually work, it would not build for the older versions of macos we wish to target. Over in cibuildwheel, there is an open question of how to do this pypa/cibuildwheel#2610 |
|
I think we should reverse course in windows and macos. We should not use cibuildwheel there, the containerization in cibuildwheel only obfuscates the scripts. We should set up a build environment, probably the easiest is with conda compilers, and then call build-openblas.sh. This means we will need to bump the x86_64 MACOSX_DEPLOYMENT_TARGET from 10.9 to 10.13 (since that is what is supported in the conda compilers), but I think that is the least bad option. I think it would simplify upstream compatibility if we use CMake in build-openblas.sh, but that is a separate issue. |
Perhaps we could open these two issues. If possible, could you please assign the CMake one to me? I'll try to add support for it in a few days. |
This whole PR is in worse shape than #220, which was passing CI. Maybe I should start again. |
|
Closing in favor of #225 |
git describe --tags --abbrev=8in OpenBLAS at theOPENBLAS_COMMIT. If I did not updateOPENBLAS_COMMIT, I incremented the wheel build number (i.e. 0.3.29.0.0 to 0.3.29.0.1)Towards #219.