Make response props parsing more robust for OpenAI compatible APIs #382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s for optional fields. This prevents crashes when the API response is missing optional fields that were previously expected to be present. Changes: - Added custom decoders to `ResponseObject` and `OutputTextContent` to provide default values for missing keys. - Made `inputTokensDetails` and `outputTokensDetails` in `ResponseUsage` optional.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that local open-ai compatible response would fail parsing oftentimes with some fields missing;
Made toolChoice and the token metrics optional to satisfy.
I can see how it might be a breaking change for some consumers but unsure if it's better to provide a default value (might also break assumptions)