Skip to content

Add short-term fallback for models that do not support stop sequences #2487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
veekaybee wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add short-term fallback for models that do not support stop sequences #2487

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e94747f
Add fallback for models that do not support stop sequences
veekaybee May 31, 2026
f76bd0d
lint
veekaybee May 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions bertopic/representation/_openai.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,12 @@ def extract_topics(
if self.exponential_backoff:
response = chat_completions_with_backoff(self.client, **kwargs)
else:
response = self.client.chat.completions.create(**kwargs)
try:
response = self.client.chat.completions.create(**kwargs)
except openai.BadRequestError as e:
if "stop" in kwargs and "unsupported parameter" in str(e).lower() and "stop" in str(e).lower():
kwargs.pop("stop", None)
response = self.client.chat.completions.create(**kwargs)

# Check whether content was actually generated
# Addresses #1570 for potential issues with OpenAI's content filter
Expand Down Expand Up @@ -268,7 +273,17 @@ def _replace_documents(prompt, docs):


def chat_completions_with_backoff(client, **kwargs):
return retry_with_exponential_backoff(
create_with_backoff = retry_with_exponential_backoff(
client.chat.completions.create,
errors=(openai.RateLimitError,),
)(**kwargs)
)
try:
return create_with_backoff(**kwargs)
except openai.BadRequestError as e:
# Addresses an issue where
if "stop" in kwargs and "unsupported parameter" in str(e).lower() and "stop" in str(e).lower():
kwargs = kwargs.copy()
kwargs.pop("stop", None)
return create_with_backoff(**kwargs)

raise
Loading