Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change in Octopus Client 3.3.x #38

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

graemefoster
Copy link
Contributor

Some new code to introspect deployments breaks against 3.3.x. Upgrading client, and fixing.
Sadly I think this will need to be another major version bump as this won't work against 3.2.x

@robdmoore
Copy link
Member

So how does this work against the Octopus API - will both libraries work against all the API versions or ...?

@robdmoore
Copy link
Member

You'll need to update the nuspec file so the dependency version is updated.

@graemefoster
Copy link
Contributor Author

graemefoster commented May 10, 2016

Nah – Octopus made a breaking change to their API from 3.2.x to 3.3.x.
It’s documented here:

http://docs.octopusdeploy.com/display/OD/Sensitive+Properties+API+Changes+in+Release+3.3

The error I received when using WebFarm deploy with 3.2 client against 3.3.x server was:

Octopus.Client.Exceptions.OctopusDeserializationException: Unable to process response from server: Error reading string. Unexpected token: StartObject. Path 'Steps[4].Actions[0].Properties.['Octopus.Action.WindowsService.CustomAccountPassword']', line 156, position 69.. Response content: {
"Id": "deploymentprocess-Projects-1",
"ProjectId": "Projects-1",
"Steps": [
{
---> Newtonsoft.Json.JsonReaderException: Error reading string. Unexpected token: StartObject. Path 'Steps[4].Actions[0].Properties.['Octopus.Action.WindowsService.CustomAccountPassword']', line 156, position 69.

@graemefoster
Copy link
Contributor Author

Done.


Cash Converters Pty Ltd
Level 18, 37 St Georges Terrace Perth WA 6000

[http://cashies.blob.core.windows.net/images/logos/facebook.jpg]https://www.facebook.com/CashConvertersAustralia

[http://cashies.blob.core.windows.net/images/logos/twitter.jpg]https://twitter.com/cashconverters

[http://cashies.blob.core.windows.net/images/logos/google_plus.jpg]https://plus.google.com/+CashConvertersAu/posts

[http://cashies.blob.core.windows.net/images/logos/youtube.jpg]http://www.youtube.com/channel/UCljcL6Hwzk5XwzPVItquK-A

[http://cashies.blob.core.windows.net/images/logos/instagram.jpg]http://instagram.com/cashconvertersaus

Go Green, Keep it on screen - think before you print

This message contains confidential information and is intended only for the individual named. If you are not the named addressee you should not use, disseminate, distribute or copy this e-mail without the author's permission. Please notify the sender immediately by e-mail if you have received this e-mail by mistake and delete this e-mail from your system. E-mail transmission cannot be guaranteed to be secure or error-free or virus free as information could be intercepted, corrupted, lost, destroyed, arrive late or incomplete, or contain viruses. The sender therefore does not accept liability for any viruses, errors or omissions in the contents of this message, which arise as a result of e-mail transmission. If verification is required please request a hard-copy version. Cash Converters, PO Box 3151, Adelaide Terrace, Perth, Australia, 6832, www.cashconverters.com.au

From: Rob Moore [mailto:[email protected]]
Sent: Monday, 9 May 2016 8:45 PM
To: MRCollective/AzureWebFarm.OctopusDeploy [email protected]
Cc: Graeme Foster [email protected]; Author [email protected]
Subject: Re: [MRCollective/AzureWebFarm.OctopusDeploy] Breaking change in Octopus Client 3.3.x (#38)

You'll need to update the nuspec file so the dependency version is updated.


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHubhttps://github.com//pull/38#issuecomment-217854086

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants