updated projects to netstandard2.0 #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k 4.6.1 and up and .net core. Now using new project structure as well as new nuget project reference instead of package reference. Updated Autofac and NSubstitute to latest versions (4.9.4 and 4.2.1, respectively). Added ignore for .vs folder. Didn't keep the .nuget solution folder because I don't see it in git. Used Jason's changes for unit test fix: Jason-eCargo@c7e62b2. Used Visual Studio 2019 to create all these changes. Chose 4.9.4 as nuget package version since that is the version of Autofac it references
main repo master branch merged into my fork repo master branch
# Conflicts: # AutofacContrib.NSubstitute.Tests/AutofacContrib.NSubstitute.Tests.csproj # AutofacContrib.NSubstitute.Tests/packages.config # AutofacContrib.NSubstitute/AutofacContrib.NSubstitute.csproj # AutofacContrib.NSubstitute/AutofacContrib.NSubstitute.nuspec # AutofacContrib.NSubstitute/packages.config
|
I'd love to get this PR done. It includes changes in another PR, converts to .net standard (making this available/working on latest .net core 2.2, 3.0, 3.1), and would fix a few issues. If we could get this merged to master and a new nuget package out I'd really appreciate it. This would allow us to stop using our internal package for this and let everyone else in the world use with new code, updated nuget packages, .net framework and .net core. @robdmoore I'd be happy to help in any further way I can. If you want to add me to maintainers I'd be happy to help |
This was referenced Jan 15, 2020
robdmoore
approved these changes
Jan 16, 2020
|
Great work @mtrtm. Thanks for this. I've released this to nuget. I've also added you as a repository maintainer. cc @MattDavies |
|
@robdmoore thanks so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated projects to .net standard 2.0 for compatibility with framework 4.6.1 and up and .net core. Now using new project structure as well as new nuget project reference instead of package reference. Updated Autofac and NSubstitute to latest versions (4.9.4 and 4.2.1, respectively). Added ignore for .vs folder. Didn't keep the .nuget solution folder because I don't see it in git. Used Jason's changes for unit test fix: Jason-eCargo@c7e62b2. Used Visual Studio 2019 to create all these changes. Chose 4.9.4 as nuget package version since that is the version of Autofac it references