Added cubed_sphere target grid test to utility/combine_topo
#861
Conversation
There was a problem hiding this comment.
@bmooremaley, this is excellent work! I'm very happy with the way you have reorganized things and the clean-up you've done along the way.
I have some suggested changes that we can discuss today.
|
Presumably, you'll need to do a commit to make the linter happy. The easiest way to do that is probably to add an extra newline somewhere (maybe at the end of the file) and then fix whatever it complains about. Make sure you do that with the conda environment loaded so pre-commit can happen. |
bmooremaley
force-pushed
the
combine-topo-to-cubedsphere
branch
from
b94f7d9 to
1ed573a
Compare
There was a problem hiding this comment.
@bmooremaley, this looks good and seems to work for the most part. I did run into an unexpected behavior that I describe below and provide a suggested fix for. I also noticed that the docstrings need some small tweaks in formatting. We use the numpydoc format so this may be a little different than what you've done in the past.
bmooremaley
force-pushed
the
combine-topo-to-cubedsphere
branch
from
1ed573a to
7c98497
Compare
There was a problem hiding this comment.
As soon as #879 goes in, I will rebase this an merge it.
Thanks for the very hard work on this, @bmooremaley!!
xylar
force-pushed
the
combine-topo-to-cubedsphere
branch
from
b50bf38 to
e8c9b70
Compare
|
A bit more debugging on how to handle |
…ine_topo, nearing complete workflow for pull request
…nd cubed_sphere remapping cases, and successfully ran for 0.1 deg and ne30 target grids
ncremap doesn't seem to be handling renormalization as we expect.
Writing SCRIP from pyremap descriptors using NETCDF3_64BIT_DATA proved to be way too slow.
xylar
force-pushed
the
combine-topo-to-cubedsphere
branch
from
87da1aa to
5b42aa2
Compare
The
ocean/utility/combine_topotest has been split into two separate tests: one for alat_lontarget grid and one for acubed_spheretarget grid. Thecubed_spheretest allows the migration tombtempestfor remapping bathymetry to MPAS grids by removing the pole singularities. The workflow for the existinglat_lontarget grid has also been updated to use remapping tools more consistently between the GEBCO and BedMachineAntarctica data sets, and between thelat_lonandcubed_spheretarget mesh workflows. Specifically, the GEBCO dataset is separated into tiles prior to remapping,ESMF_RegridWeightGenis used for building weights files, andncremapis used for the final remapping step.Checklist
Testingin this PR) any testing that was used to verify the changes