Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Mesh: SOwISC12to30E3r4 #829

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from
Draft

New Mesh: SOwISC12to30E3r4 #829

wants to merge 15 commits into from

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Jun 10, 2024

Long name: SOwISC12to30kmL80E3SMv3r4

This version of the Southern Ocean Regionally Refined Mesh (SORRM) has resolution that is:

  • 12 km resolution around Antarctica
  • 30 km elsewhere

It is intended to be similar to the Icos30 mesh except in the Southern Ocean and around Antarctica.

This mesh differs from r3 in #807 in that:

  • MALI topography as well as masks for land ice, floating ice and ocean get combined with BedMachine Antarctica/GEBCO.

Checklist

  • User's Guide has been updated
  • Developer's Guide has been updated
  • API documentation in the Developer's Guide (api.rst) has any new or modified class, method and/or functions listed
  • Documentation has been built locally and changes look as expected
  • The E3SM-Project submodule has been updated with relevant E3SM changes
  • Document (in a comment titled Testing in this PR) any testing that was used to verify the changes

@xylar xylar added enhancement New feature or request ocean in progress This PR is not ready for review or merging E3SM PR required labels Jun 10, 2024
@xylar
Copy link
Collaborator Author

xylar commented Jun 10, 2024

This is based off of #807 (which is based off of #813) so it will be a bit before this is ready to go in. It also needs documentation.

@xylar xylar force-pushed the add-mali-topo branch 3 times, most recently from 0b54306 to 959da20 Compare June 12, 2024 16:17
@xylar
Copy link
Collaborator Author

xylar commented Jun 12, 2024

Comparison with SOwISC12to30E3r3

Here are the landIceMask fields for the SORRM mesh with MALI topography:
mali_topo_land_ice_mask

And the same but with BedMachine from #807:
sowiscr3_land_ice_mask

@xylar xylar force-pushed the add-mali-topo branch 2 times, most recently from be2486f to b5e6880 Compare July 8, 2024 12:36
@xylar
Copy link
Collaborator Author

xylar commented Jul 8, 2024

Updated Comparison with SOwISC12to30E3r3

Here are the landIceMask fields for the SORRM mesh with MALI (AIS_2to10km) topography:
sorrm_ais_2to10km_land_ice_mask

And the same but with BedMachine from #807:
sorrm_r3_land_ice_mask

@xylar
Copy link
Collaborator Author

xylar commented Jul 8, 2024

I was able to run the workflow through the performance test. In a discussion with @cbegeman, @matthewhoffman and @trhille, we decided we'd like to work with a 4km initial condition that's more similar to the 2km one I used in the plots above, and that that initial condition would also be swapped into E3SM-Project/E3SM#6440, the PR bringing in the new MALI AIS meshes and initial conditions.

@xylar xylar force-pushed the add-mali-topo branch 2 times, most recently from e512590 to 824f8f5 Compare July 26, 2024 09:31
@xylar xylar self-assigned this Oct 22, 2024
@xylar xylar requested a review from matthewhoffman October 22, 2024 14:41
@xylar xylar changed the title Add a step for remapping topography from MALI New Mesh: SOwISC12to30E3r4 Oct 22, 2024
@xylar xylar added the new mesh An E3SM mesh for special review label Oct 22, 2024
@xylar xylar marked this pull request as ready for review October 22, 2024 18:44
@xylar xylar added sea ice and removed in progress This PR is not ready for review or merging labels Oct 22, 2024
@xylar
Copy link
Collaborator Author

xylar commented Oct 23, 2024

Another Updated Comparison with SOwISC12to30E3r3

Here are the landIceMask fields for the SORRM r4 mesh with MALI (AIS_4to20km) topography:
sorrmr4_land_ice_mask

And the same but SORRM r3 with BedMachine topography from #807:
sorrmr3_land_ice_mask

@xylar
Copy link
Collaborator Author

xylar commented Oct 23, 2024

The same as above but zooming in on the Amundsen Sea.

SORRM r4:
sorrmr4_amundsen

SORRM r3:
sorrmr3_amundsen

@cbegeman
Copy link
Collaborator

@xylar have you been looking at all at landIceFloatingFraction?

@xylar xylar added the in progress This PR is not ready for review or merging label Jan 6, 2025
@xylar xylar marked this pull request as draft January 6, 2025 13:41
@xylar xylar force-pushed the add-mali-topo branch 3 times, most recently from 2b34f28 to 5974cb4 Compare January 6, 2025 16:20
@xylar
Copy link
Collaborator Author

xylar commented Jan 7, 2025

The land-ice mask for the Amundsen sea is looking reasonable with the latest MALI topography dataset (AIS_4to20km_20241118_relaxation_0TGmelt_10yr.20241224.nc):
land_ice_mask

@xylar
Copy link
Collaborator Author

xylar commented Jan 15, 2025

I made a version of the culled MPAS-Ocean mesh that includes grounded ice below sea level:

land_ice_grounded_fraction

It looks like this adds only about 5% more cells (even though all added cells are in the high-res region). That certainly seems acceptable.

@cbegeman
Copy link
Collaborator

cbegeman commented Jan 15, 2025

@xylar Great! I'm wondering about the distribution of 0 < landIceGroundedFraction < 1. It looks from the figure above that these cells are only along the transition between grounded and floating ice or open ocean, and not along the transition from grounded ice to land above sea level. Is this intentional?

@xylar
Copy link
Collaborator Author

xylar commented Jan 15, 2025

@cbegeman, I think we do a flood fill to remove all land-ice-to-land so, yeah, that transition is intentionally not there and I don't think we want it.

@xylar
Copy link
Collaborator Author

xylar commented Jan 15, 2025

I think that might have been one of the important fixes I had to make in SORRMr3 -- if I accidentally didn't eliminate the land-ice-to-land transition, I ended up with weird ice drafts above sea level in some cases because of interpolation between areas that are above and below sea level.

@cbegeman
Copy link
Collaborator

On giving this a little more thought I agree that the hard transition is what we want. Thanks for explaining the reasoning a bit more.

xylar added 14 commits January 15, 2025 13:11
MALI topogrpahy gets combined with BedMachine Antarctica/GEBCO.

For now, the masks for the grounding line, calving front, etc.
are form BedMachine, not MALI, so that the same horizontal mesh
and mapping files can be used with BedMachine and MALI topogrpahy.
These will change the locaiton of the grounding line and calving
front, so that the resulting ocean grid will be different from
the equivalent from BedMachine.
Move ocean_density and sea_level to config options
MOAB commands are updated to be more like recent development in
remap_topography and are organized into more helper methods.
@xylar xylar requested a review from cbegeman January 15, 2025 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E3SM PR finished enhancement New feature or request in progress This PR is not ready for review or merging new mesh An E3SM mesh for special review ocean sea ice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants