-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Mesh: SOwISC12to30E3r4 #829
base: main
Are you sure you want to change the base?
Conversation
0b54306
to
959da20
Compare
Comparison with SOwISC12to30E3r3Here are the And the same but with BedMachine from #807: |
be2486f
to
b5e6880
Compare
Updated Comparison with SOwISC12to30E3r3Here are the And the same but with BedMachine from #807: |
I was able to run the workflow through the performance test. In a discussion with @cbegeman, @matthewhoffman and @trhille, we decided we'd like to work with a 4km initial condition that's more similar to the 2km one I used in the plots above, and that that initial condition would also be swapped into E3SM-Project/E3SM#6440, the PR bringing in the new MALI AIS meshes and initial conditions. |
e512590
to
824f8f5
Compare
Another Updated Comparison with SOwISC12to30E3r3Here are the And the same but SORRM r3 with BedMachine topography from #807: |
@xylar have you been looking at all at |
2b34f28
to
5974cb4
Compare
@xylar Great! I'm wondering about the distribution of |
@cbegeman, I think we do a flood fill to remove all land-ice-to-land so, yeah, that transition is intentionally not there and I don't think we want it. |
I think that might have been one of the important fixes I had to make in SORRMr3 -- if I accidentally didn't eliminate the land-ice-to-land transition, I ended up with weird ice drafts above sea level in some cases because of interpolation between areas that are above and below sea level. |
On giving this a little more thought I agree that the hard transition is what we want. Thanks for explaining the reasoning a bit more. |
MALI topogrpahy gets combined with BedMachine Antarctica/GEBCO. For now, the masks for the grounding line, calving front, etc. are form BedMachine, not MALI, so that the same horizontal mesh and mapping files can be used with BedMachine and MALI topogrpahy.
These will change the locaiton of the grounding line and calving front, so that the resulting ocean grid will be different from the equivalent from BedMachine.
Move ocean_density and sea_level to config options
MOAB commands are updated to be more like recent development in remap_topography and are organized into more helper methods.
Long name: SOwISC12to30kmL80E3SMv3r4
This version of the Southern Ocean Regionally Refined Mesh (SORRM) has resolution that is:
It is intended to be similar to the Icos30 mesh except in the Southern Ocean and around Antarctica.
This mesh differs from r3 in #807 in that:
Checklist
api.rst
) has any new or modified class, method and/or functions listedE3SM-Project
submodule has been updated with relevant E3SM changesTesting
in this PR) any testing that was used to verify the changes