Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BP-1262: Small codebase improvements #179

Merged
merged 6 commits into from
Jan 30, 2025
Merged

BP-1262: Small codebase improvements #179

merged 6 commits into from
Jan 30, 2025

Conversation

andreparames
Copy link
Contributor

@andreparames andreparames commented Dec 20, 2024 •
edited by jira bot
Loading

Just some code cleanup, particularly functions that have incorrect typing hints. No change in behavior is expected.

Ticket: BP-1262

  • Make sure you are opening from a topic/feature/bugfix branch
  • Ensure that the PR title represents the desired changes
  • Ensure that the PR description detail the desired changes
  • Link to relevant issues in GitHub or Jira
    - [ ] Link to relevant pull requests, esp. upstream and downstream changes
    - [ ] Ensure you have provided tests - that demonstrates feature works or fixes the issue

@andreparames andreparames self-assigned this Dec 20, 2024
diasdm
diasdm requested changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@diasdm diasdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, left a few comments

movai_core_shared/common/time.py Show resolved Hide resolved
movai_core_shared/core/message_client.py Show resolved Hide resolved
movai_core_shared/core/message_client.py Show resolved Hide resolved
movai_core_shared/core/zmq/zmq_client.py Outdated Show resolved Hide resolved
movai_core_shared/core/zmq/zmq_helpers.py Show resolved Hide resolved
movai_core_shared/core/zmq/zmq_server.py Show resolved Hide resolved
@diasdm diasdm self-requested a review January 29, 2025 10:10
diasdm
diasdm reviewed Jan 29, 2025
View reviewed changes
Copy link
Contributor

@diasdm diasdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version bump and add to changelog?

@andreparames
Copy link
Contributor Author

Version bump and add to changelog?

Thanks! Done.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
80.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@andreparames andreparames merged commit 1899822 into main Jan 30, 2025
8 checks passed
@andreparames andreparames deleted the task/BP-1262/codebase-improvements branch January 30, 2025 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diasdm diasdm diasdm approved these changes

@duartecoelhomovai duartecoelhomovai Awaiting requested review from duartecoelhomovai

Assignees

@andreparames andreparames

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andreparames @diasdm @OttoMation-Movai