Skip to content

FP-3141: Changed DISABLED_VALUE constant from None to {{DISABLED_VALUE}} #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

manuelnogueiramov
Copy link
Contributor

@manuelnogueiramov manuelnogueiramov commented Mar 24, 2025

FP-3141

  • Changed DISABLED_VALUE constant from None to {{DISABLED_VALUE}}

I'm positive that this will affect previously set Disabled Values. They will not show as disabled in all the Flows / Node instances, but they will show as None instead. Any suggestions on how to fix this? - @diasnad @diasdm

@manuelnogueiramov manuelnogueiramov added bug Something isn't working enhancement New feature or request refactor When some refactor was done labels Mar 24, 2025
@manuelnogueiramov manuelnogueiramov self-assigned this Mar 24, 2025
@manuelnogueiramov manuelnogueiramov requested a review from a team as a code owner March 24, 2025 18:36
Copy link

@diasdm
Copy link
Collaborator

diasdm commented Mar 25, 2025

If I understand the issue well, the user is setting the parameter default value to the value used to indicate a disabled parameter (None). To properly fix this we need an actual enabled field on the parameter, which is something that I don't see happening soon...

I've checked checked the behavior on EE 2.3.1, at least in the Node editor the parameter doesn't show as disabled, do you know how it was detected then?

@manuelnogueiramov
Copy link
Contributor Author

If I understand the issue well, the user is setting the parameter default value to the value used to indicate a disabled parameter (None). To properly fix this we need an actual enabled field on the parameter, which is something that I don't see happening soon...

I've checked checked the behavior on EE 2.3.1, at least in the Node editor the parameter doesn't show as disabled, do you know how it was detected then?

Not 100% but I remember debating it back in the day. It was either by passing null or undefined which might be as problematic as the None was.

Copy link

@pedro-cristovao pedro-cristovao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code seems ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request refactor When some refactor was done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants