Feat: App list view #1170
Feat: App list view #1170
Conversation
|
The list view has some more fixes and looks like this
|
KorigamiK
changed the title
|
Oh and #995 too! |
|
@MM2-0 would appreciate a review here |
|
Could you please also add alphabet to the right side of screen for fast scrolling |
I don't think it is necessary that the results will be sorted by alphabets when searching |
| val gridList: Boolean = true, | ||
| val gridListIcons: Boolean = true, |
There was a problem hiding this comment.
List shouldn't be the default value
| package de.mm20.launcher2.preferences.migrations | ||
|
|
||
| import androidx.datastore.core.DataMigration | ||
| import de.mm20.launcher2.preferences.LauncherSettingsData | ||
|
|
||
| class Migration4: DataMigration<LauncherSettingsData> { | ||
| override suspend fun cleanUp() { | ||
| } | ||
|
|
||
| override suspend fun shouldMigrate(currentData: LauncherSettingsData): Boolean { | ||
| return currentData.schemaVersion < 4 | ||
| } | ||
|
|
||
| override suspend fun migrate(currentData: LauncherSettingsData): LauncherSettingsData { | ||
| return currentData.copy( | ||
| schemaVersion = 4, | ||
| gridList = true, | ||
| gridListIcons = true, | ||
| ) | ||
| } | ||
| } |
There was a problem hiding this comment.
This migration is unnecessary, gridList already has a default value which is used when no value exists in the currently saved settings file.
| @@ -15,7 +15,7 @@ class Migration3: DataMigration<LauncherSettingsData> { | |||
| return currentData.copy( | |||
| schemaVersion = 3, | |||
| locationSearchProviders = buildSet { | |||
| if (currentData.locationSearchEnabled) { | |||
| if (currentData.locationSearchProviders.isNotEmpty()) { | |||
There was a problem hiding this comment.
Why? Because locationSearchEnabled is deprecated? But this migration is the only reason that field still exists…
It used to be a simple true/false flag but after plugins were added, it is now a list of providers. Since we don't know whether the user has disabled location search before, this migration is necessary.
|
Implementation looks good so far, but I'm not a fan of how huge these labels are. Is there a reason you chose such a big font? |
Thanks. I wanted the font to be like yam launcher which is nice and a little more minimalist. However I do think we can have the font size customisable for others on their preference too. sorry for not looking at the requests earlier. |
Addresses #1162 #710
This allows for creating a list like app layout which don't show icons in the app list.