-
Notifications
You must be signed in to change notification settings - Fork 0
[DO NOT MERGE] Citation prototyping #205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
matt-bernhardt
wants to merge
12
commits into
main
Choose a base branch
from
citation-rake-task
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
568b3d2
to
f8a135a
Compare
f8a135a
to
13382dc
Compare
66365ab
to
d59da26
Compare
TODO: Remove or better contextualize the excalidraw diagram
This allows the application to support labelled records for the evaluation of its internal algorithms. Along with this change, the rake task to load search events - which is how labelled data will be supplied to the application - is updated to support a label field. This includes a new test to confirm that support, and a new cassette holding labelled data.
With the data model and ingestor upgraded, we now build a way for the application to process that labelled data, and calculate an f1 score for the citation detector, and display it in the UI.
d59da26
to
481f3a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is very much a work in progress, and does not necessarily hold code that we'll need in the application over the long term. It exists to allow us to measure the current citation detector's performance for as long as that feature exists here - which may not be for too much longer.