Skip to content

[WIP] Abstraction in custom post type plugins #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

matt-bernhardt
Copy link
Member

This demonstrates an apparent way to get around the code repetition in the mitlib-post-FOO plugins which descend from the base mitlib-post plugin.

Developer

Secrets

  • All new secrets have been added to Pantheon tiers
  • Relevant secrets have been updated in Github Actions
  • All new secrets documented in README

Documentation

  • Project documentation has been updated
  • No documentation changes are needed

Accessibility

  • ANDI or Wave has been run in accordance to
    our guide and
    all issues introduced by these changes have been resolved or opened as new
    issues (link to those issues in the Pull Request details above)

Stakeholder approval

  • Stakeholder approval has been confirmed
  • Stakeholder approval is not needed

Dependencies

YES | NO dependencies are updated

Code Reviewer

  • The commit message is clear and follows our guidelines
    (not just this pull request message)
  • The changes have been verified
  • The documentation has been updated or is unnecessary
  • New dependencies are appropriate or there were no changes

This demonstrates an apparent way to get around the code repetition in the mitlib-post-FOO plugins which descend from the base mitlib-post plugin.
@matt-bernhardt matt-bernhardt marked this pull request as draft March 23, 2023 13:32
@matt-bernhardt matt-bernhardt changed the title Abstraction in custom post type plugins [WIP] Abstraction in custom post type plugins Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant