feat: allow factories to deal with move-only constructor arguments #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andre-nguyen
force-pushed
the
feat/move_only_arguments_factory
branch
from
a16059e to
13e5078
Compare
nathanhhughes
approved these changes
Feb 25, 2025
There was a problem hiding this comment.
Looks great, thanks for fixing this! Definitely easy to forget about move-only types until you need them, so it's very appreciated you caught this 😄
(closes #43)
|
Thank you for the quick review! Had to amend line 245 of factory.hpp because I forgot a |
|
Oh I forgot, I don't have merge rights, you'll have to do it for me 😇 |
|
Thanks for this fix @andre-nguyen and the quick reply @nathanhhughes, looks great! |
andre-nguyen
added a commit
to andre-nguyen/config_utilities
that referenced
this pull request
Feb 28, 2025
…ments (MIT-SPARK#44)" This reverts commit 4a35323.
Schmluk
pushed a commit
that referenced
this pull request
Feb 28, 2025
* Revert "feat: allow factories to deal with move-only constructor arguments (#44)" This reverts commit 4a35323. * fix: support move-only parameter types in factories using std::move The previous implementation using std::forward incorrectly used forwarding references. Given that the types are not deduced but actually explicitly written, '&&' is not actually a forwarding reference. Thus this commit replaces std::forward with std::move.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #43
Best explanation I've found about this is here.