Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/labelspaces #30

Merged
merged 10 commits into from
Feb 14, 2025
2 changes: 2 additions & 0 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,10 @@ add_library(
src/dynamic_scene_graph.cpp
src/edge_attributes.cpp
src/edge_container.cpp
src/labelspace.cpp
src/layer_view.cpp
src/mesh.cpp
src/metadata.cpp
src/node_attributes.cpp
src/node_symbol.cpp
src/printing.cpp
Expand Down
1 change: 1 addition & 0 deletions MANIFEST.in
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,4 @@ graft src
graft include
graft cmake
graft python/bindings
graft third_party
3 changes: 2 additions & 1 deletion include/spark_dsg/dynamic_scene_graph.h
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
#include <nlohmann/json.hpp>
#include <type_traits>

#include "spark_dsg/metadata.h"
#include "spark_dsg/scene_graph_layer.h"
#include "spark_dsg/spark_dsg_fwd.h"

Expand Down Expand Up @@ -483,7 +484,7 @@ class DynamicSceneGraph {
std::shared_ptr<Mesh> mesh() const;

//! Any extra information about the graph
nlohmann::json metadata;
Metadata metadata;

protected:
Layer& layerFromKey(const LayerKey& key);
Expand Down
4 changes: 2 additions & 2 deletions include/spark_dsg/edge_attributes.h
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,9 @@
* -------------------------------------------------------------------------- */
#pragma once
#include <memory>
#include <nlohmann/json.hpp>
#include <ostream>

#include "spark_dsg/metadata.h"
#include "spark_dsg/serialization/attribute_registry.h"

namespace spark_dsg {
Expand Down Expand Up @@ -78,7 +78,7 @@ struct EdgeAttributes {
//! the weight of the edge
double weight;
//! Arbitrary metadata about the edge
nlohmann::json metadata;
Metadata metadata;

/**
* @brief output attribute information
Expand Down
135 changes: 135 additions & 0 deletions include/spark_dsg/labelspace.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,135 @@
/* -----------------------------------------------------------------------------
* Copyright 2022 Massachusetts Institute of Technology.
* All Rights Reserved
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions are met:
*
* 1. Redistributions of source code must retain the above copyright notice,
* this list of conditions and the following disclaimer.
*
* 2. Redistributions in binary form must reproduce the above copyright notice,
* this list of conditions and the following disclaimer in the documentation
* and/or other materials provided with the distribution.
*
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND
* ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
* WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
* DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE
* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
* SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
* CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
* OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*
* Research was sponsored by the United States Air Force Research Laboratory and
* the United States Air Force Artificial Intelligence Accelerator and was
* accomplished under Cooperative Agreement Number FA8750-19-2-1000. The views
* and conclusions contained in this document are those of the authors and should
* not be interpreted as representing the official policies, either expressed or
* implied, of the United States Air Force or the U.S. Government. The U.S.
* Government is authorized to reproduce and distribute reprints for Government
* purposes notwithstanding any copyright notation herein.
* -------------------------------------------------------------------------- */
#pragma once
#include <nlohmann/json.hpp>
#include <optional>

#include "spark_dsg/node_attributes.h"
#include "spark_dsg/spark_dsg_fwd.h"

namespace spark_dsg {

/**
* @brief Inverse mapping between numerical labels and category names
*
* Generally intended to be instantiated and stored in the scene graph metadata (on a
* per-layer basis)
*/
class Labelspace {
public:
Labelspace() = default;

/**
* @brief Construct the label space from a mapping between numerical labels and
* category names
*/
explicit Labelspace(const std::map<SemanticLabel, std::string>& label_to_names);

/**
* @brief Construct the labelspace from names (assumes the numerical labels correspond
* to vector indices)
*/
explicit Labelspace(const std::vector<std::string>& names);

/**
* @brief Pull the labelspace from scene graph metadata
*/
static Labelspace fromMetadata(const DynamicSceneGraph& graph,
LayerId layer,
PartitionId partition = 0);

/**
* @brief Pull the labelspace from scene graph metadata
*/
static Labelspace fromMetadata(const DynamicSceneGraph& graph,
const std::string& name);

/**
* @brief Get whether or not the label space is populated
*/
bool empty() const;

/**
* @brief Labelspaces are valid if they aren't empty
*/
inline operator bool() const { return !empty(); }

/**
* @brief Get the corresponding category name to the label if it exists
*/
std::optional<std::string> getCategory(SemanticLabel label) const;

/**
* @brief Get the corresponding label to the name if it exists.
*/
std::optional<SemanticLabel> getLabel(const std::string& category) const;

/**
* @brief Utility function to lookup corresponding category name to node
*/
std::string getCategory(const SemanticNodeAttributes& attrs,
const std::string& unknown_name = "UNKNOWN") const;

/**
* @brief Save the label space to metadata
*/
void save(DynamicSceneGraph& graph, LayerId layer, PartitionId partition = 0) const;

/**
* @brief Save the label space to metadata
*/
void save(DynamicSceneGraph& graph, const std::string& name) const;

private:
std::map<SemanticLabel, std::string> label_to_name_;
std::map<std::string, SemanticLabel> name_to_label_;

public:
/**
* @brief Get constant reference to label-name mapping
*/
const std::map<SemanticLabel, std::string>& labels_to_names() const {
return label_to_name_;
}

/**
* @brief Get constant reference to label-name mapping
*/
const std::map<std::string, SemanticLabel>& names_to_labels() const {
return name_to_label_;
}
};

} // namespace spark_dsg
52 changes: 52 additions & 0 deletions include/spark_dsg/metadata.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
/* -----------------------------------------------------------------------------
* Copyright 2022 Massachusetts Institute of Technology.
* All Rights Reserved
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions are met:
*
* 1. Redistributions of source code must retain the above copyright notice,
* this list of conditions and the following disclaimer.
*
* 2. Redistributions in binary form must reproduce the above copyright notice,
* this list of conditions and the following disclaimer in the documentation
* and/or other materials provided with the distribution.
*
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND
* ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
* WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
* DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE
* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
* SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
* CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
* OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*
* Research was sponsored by the United States Air Force Research Laboratory and
* the United States Air Force Artificial Intelligence Accelerator and was
* accomplished under Cooperative Agreement Number FA8750-19-2-1000. The views
* and conclusions contained in this document are those of the authors and should
* not be interpreted as representing the official policies, either expressed or
* implied, of the United States Air Force or the U.S. Government. The U.S.
* Government is authorized to reproduce and distribute reprints for Government
* purposes notwithstanding any copyright notation herein.
* -------------------------------------------------------------------------- */
#pragma once
#include <nlohmann/json.hpp>

namespace spark_dsg {

struct Metadata {
Metadata();
Metadata(const nlohmann::json& contents);
const nlohmann::json& get() const;
inline const nlohmann::json& operator()() const { return get(); }
void set(const nlohmann::json& new_metadata);
void add(const nlohmann::json& to_add);

private:
nlohmann::json contents_;
};

} // namespace spark_dsg
4 changes: 2 additions & 2 deletions include/spark_dsg/node_attributes.h
Original file line number Diff line number Diff line change
Expand Up @@ -38,14 +38,14 @@
#include <list>
#include <map>
#include <memory>
#include <nlohmann/json.hpp>
#include <optional>
#include <ostream>
#include <string>

#include "spark_dsg/bounding_box.h"
#include "spark_dsg/color.h"
#include "spark_dsg/mesh.h"
#include "spark_dsg/metadata.h"
#include "spark_dsg/scene_graph_types.h"
#include "spark_dsg/serialization/attribute_registry.h"

Expand Down Expand Up @@ -115,7 +115,7 @@ struct NodeAttributes {
//! whether the node was observed by Hydra, or added as a prediction
bool is_predicted;
//! Arbitrary node metadata
nlohmann::json metadata;
Metadata metadata;

/**
* @brief output attribute information
Expand Down
8 changes: 2 additions & 6 deletions include/spark_dsg/serialization/attribute_serialization.h
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ void Visitor::to(nlohmann::json& record, const Attrs& attrs) {
visitor.type_ = Type::JSON_WRITE;
visitor.impl_ = std::make_unique<JsonWriter>(&record);
record["type"] = attrs.registration().name;
record["metadata"] = attrs.metadata;
record["metadata"] = attrs.metadata();
attrs.serialization_info();
visitor.impl_.reset();
}
Expand All @@ -184,11 +184,7 @@ void Visitor::to(BinarySerializer& serializer, const Attrs& attrs) {
visitor.type_ = Type::BINARY_WRITE;
visitor.impl_ = std::make_unique<BinaryWriter>(&serializer);
serializer.write(attrs.registration().type_id);

// serialize metadata
std::stringstream ss;
ss << attrs.metadata;
serializer.write(ss.str());
serializer.write(attrs.metadata().dump());

attrs.serialization_info();
visitor.impl_.reset();
Expand Down
Loading