Add Dockerfile #45
Add Dockerfile #45
Conversation
ruffsl
force-pushed
the
patch-1
branch
2 times, most recently
from
33e4ff2 to
39d9497
Compare
| @@ -0,0 +1,5 @@ | |||
| repositories: | |||
There was a problem hiding this comment.
What is the point of having an overlay/underlay.repos ?
Also we should document this in the Readme.md as well.
There was a problem hiding this comment.
Having separate overlay and underlay workspaces allows one to avoid having to rebuild unchanged upstream dependencies that changed downstream packages rely on. You can read more on this here:
https://index.ros.org/doc/ros2/Tutorials/Colcon-Tutorial/#source-an-underlay
This is used in conjunction with docker layer caching to succinctly build arbitrary package dependencies in whatever order they may require, and still cache that workspace to be independent of the source package in development.
And perhaps more than you'd ever need to know about build tools:
http://design.ros2.org/articles/build_tool.html
There was a problem hiding this comment.
I'll push a commit with some updated build instructions.
checkout entire overlay but copy over local source
|
@ToniRV is there anything else this PR needs for to be merged? |
|
@ruffsl I need to hold these PRs bcs we are in the middle of the Go-SEEK challenge, and this might break things... |
This PR adds an example Dockerfile for building this package as well as any needed underlay repos.