Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EQL Query Generation Modules #346

Merged
merged 13 commits into from
Oct 30, 2019
Merged

EQL Query Generation Modules #346

merged 13 commits into from
Oct 30, 2019

Conversation

blaverick62
Copy link
Contributor

I've added two new files to the project: eql.py in expansion/ and endgame_export.py in export_mod/. Both of these files describe modules that generate Event Query Language directly from MISP events. This is useful for SOCs that also use Endgame, since they can copy/paste the queries directly to search for that particular MISP event. eql.py is a single attribute "wrapper" enrichment that makes a single EQL query. mass_eql_export is an export module that takes all Endgame-relevant attributes and generates a large EQL for all of them. This is the first version, and will have improvements over time. Here is a link to a reference for EQL: https://eql.readthedocs.io/

@lgtm-com
Copy link

lgtm-com bot commented Oct 30, 2019

This pull request introduces 4 alerts when merging dc4c09f into d0ddfb3 - view on LGTM.com

new alerts:

  • 4 for Unused import

@codecov
Copy link

codecov bot commented Oct 30, 2019

Codecov Report

Merging #346 into master will increase coverage by 0.11%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #346      +/-   ##
==========================================
+ Coverage   18.58%   18.69%   +0.11%     
==========================================
  Files          96       98       +2     
  Lines        7916     7984      +68     
==========================================
+ Hits         1471     1493      +22     
- Misses       6445     6491      +46
Impacted Files Coverage Δ
misp_modules/modules/expansion/__init__.py 100% <ø> (ø) ⬆️
misp_modules/modules/export_mod/__init__.py 100% <100%> (ø) ⬆️
misp_modules/modules/export_mod/mass_eql_export.py 30.76% <30.76%> (ø)
misp_modules/modules/expansion/eql.py 34.48% <34.48%> (ø)
...isp_modules/modules/expansion/virustotal_public.py 24% <0%> (-0.17%) ⬇️
misp_modules/modules/expansion/virustotal.py 13.93% <0%> (-0.09%) ⬇️
misp_modules/modules/expansion/urlscan.py 0% <0%> (ø) ⬆️
misp_modules/modules/expansion/securitytrails.py 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0ddfb3...717be2b. Read the comment docs.

@adulau adulau merged commit c3c6f1a into MISP:master Oct 30, 2019
@adulau
Copy link
Member

adulau commented Oct 30, 2019

Thank you very much, this is a great contribution! If you have the time to update the documentation of the modules that would be great and show the availability of the modules to other users.

@blaverick62
Copy link
Contributor Author

blaverick62 commented Oct 30, 2019 via email

@iglocska
Copy link
Member

Woah, awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants