Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/merge tab mirror compare #34

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

bordoray
Copy link
Collaborator

Close #22

What I did(変更内容)

  • Mirror panel is tabified with others
  • Mirror panel size to be same with main map canvas
  • Size can be set by user after hand
image

@bordoray bordoray requested review from nbayashi and Copilot March 13, 2025 13:15
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

A PR to tabify the mirror panel on the right side of the QGIS window and dynamically set its width based on the main map canvas, while also introducing utility functions to work with right dockwidgets.

  • Added functions get_right_dockwidgets and set_panel_width in utils.py.
  • Updated process.py to compute and apply the panel width and tabify dock widgets for mirror comparison.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
comparator/process.py Implements mirror panel tabification and width logic
comparator/utils.py Adds utility functions and imports required types
Comments suppressed due to low confidence (1)

comparator/process.py:250

  • There is an inconsistency in naming with mirror_widget used here versus mirror_dock_widget used earlier. Use a single consistent variable name to avoid confusion.
mirror_widget.refresh()

@bordoray bordoray self-assigned this Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When active mirror compare mode, merge right panels in Tab mode
1 participant