Print all test case error messages together at the end #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #745 +/- ##
=======================================
Coverage 43.63% 43.63%
=======================================
Files 61 61
Lines 16893 16893
Branches 1948 1948
=======================================
Hits 7372 7372
Misses 8404 8404
Partials 1117 1117 ☔ View full report in Codecov by Sentry. |
sbryngelson
reviewed
Nov 24, 2024
sbryngelson
requested changes
Nov 24, 2024
There was a problem hiding this comment.
@henryleberre might comment on the 'cleanness' of the toolchain implementation. For me, it seems reasonable and gets the job done.
|
Is this in conflict with something added by @henryleberre in #737 ? |
|
Merged without issue |
sbryngelson
approved these changes
Nov 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have recently found the behavior described in #744 to be annoying. This PR addresses that by keeping a list of all failed tests and printing the errors all together at the end.
Fixes #744
Type of change
Please delete options that are not relevant.
Scope
How Has This Been Tested?
Test 1: I intentionally caused tests to fail due to tolerance by commenting out
dvd(0)in the fifth order WENO reconstruction so the solution would be wrong. The resulting output of./mfc.sh test -j 1 -o bc=-1 > test1.txt(without coloring) istest1.txt
Test 2: Intentionally caused tests to fail due to NaNs by commenting out
beta(0)in the fifth-order WENO reconstruction. The resulting output of./mfc.sh test -j 1 -o bc=-1 > test2.txt(without color) istest2.txt
Test 3: Intentionally caused tolerance errors in the WENO routine and skipped some tests. The result of running
./mfc.sh test -j 8 -o 1D -% 80 > test4.txt(without color) istest4.txt