Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/concurrency improvements #16

Merged
merged 11 commits into from
Apr 3, 2024
Merged

Conversation

roanutil
Copy link
Member

Various fixes and cleanups to help with concurrency warnings and prepare for future major release with breaking changes

roanutil added 11 commits March 22, 2024 10:14
…an early, naive attempt at a concrete type for MockOutput.

feature/concurrency-improvements
…e' implementations

feature/concurrency-improvements
…tation of MockOuput

feature/concurrency-improvements
feature/concurrency-improvements
… previous versions

feature/concurrency-improvements
…sts. Wouldn't it be better to get a hard failure if it throws?

feature/concurrency-improvements
… previous versions on start methods missed earlier

feature/concurrency-improvements
…ndled and add cancellation tests

feature/concurrency-improvements
… Fix incorrect use of StrictConcurrency feature

feature/concurrency-improvements
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 85.41667% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 76.15%. Comparing base (546d9b3) to head (8f2b30c).

Files Patch % Lines
...erviceTests/NetworkServiceTests+Cancellation.swift 81.48% 10 Missing ⚠️
.../NetworkServiceTestHelper/MockNetworkService.swift 80.95% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
+ Coverage   72.67%   76.15%   +3.47%     
==========================================
  Files          27       28       +1     
  Lines         666      717      +51     
==========================================
+ Hits          484      546      +62     
+ Misses        182      171      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roanutil roanutil merged commit 778c696 into main Apr 3, 2024
6 checks passed
@roanutil roanutil deleted the feature/concurrency-improvements branch April 3, 2024 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants