GH-744: Prepare for merge #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* GH-500: ready for an urged live test * GH-500: probably finished the deployment of Base, let's get the QA going * GH-500: removed an eprintln! * GH-500: version changed to 0.8.1 --------- Co-authored-by: Bert <[email protected]>
Signed-off-by: KauriHero <[email protected]>
* GH-606: Initialize start_block to none to use latest block * GH-606: Apply PR feedback changes * GH-606: Apply PR feedback changes * GH-606: Apply PR feedback changes * GH-606: Apply PR review 4 feedback changes * GH-606: Squashing commits - Save start_block_nbr if no msg but send as non-Option - Always commit - Reduce logging levels and simplify - Follow the Option naming pattern * GH-600: set_start_block only called in accountant/scanners/mod.rs * GH-606: PR Feedback - parameterize a test * GH-606: Address PR feedback * GH-606: Implement parameterized test without crate macro
…ess_transaction_receipts
…_receipts_with_an_empty_vector
…are_recorded_in_databases
bertllll
reviewed
Jan 3, 2025
multinode_integration_tests/tests/communication_failure_test.rs
Outdated
Show resolved
Hide resolved
node/src/accountant/scanners/mid_scan_msg_handling/payable_scanner/test_utils.rs
Outdated
Show resolved
Hide resolved
| Copyright (c) 2019-2022, MASQ Network | ||
|
|
||
| Copyright (c) 2017-2019, Substratum LLC and/or its affiliates. All rights reserved. | ||
| Copyright (c) 2019-2024, MASQ Network |
There was a problem hiding this comment.
We should probably create a card in which we'll replace the year 2024 for 2025 in all occurrences of these copyrights.
There was a problem hiding this comment.
Here's the new card - #569
node/src/blockchain/blockchain_interface/blockchain_interface_web3/utils.rs
Outdated
Show resolved
Hide resolved
node/src/blockchain/blockchain_interface/blockchain_interface_web3/utils.rs
Outdated
Show resolved
Hide resolved
| // &to[2..], | ||
| // expected_body_suffix | ||
| // ); | ||
| // assert_eq!(bodies, vec!(expected_body)); |
There was a problem hiding this comment.
I just want to assure myself that you really agree this has been an intentionally left comment.
There was a problem hiding this comment.
We needed this for historical point of view. So, I have migrated it to the card itself - #543 (comment)
| // &to[2..], | ||
| // expected_body_suffix | ||
| // ); | ||
| // assert_eq!(bodies, vec!(expected_body)); |
There was a problem hiding this comment.
Okay, you seem to have been consistent in being driven by this certain idea. That's a praise.
bertllll
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.