Check if required inputs exist in pipeline.sh#8
Open
jakepalmer wants to merge 1 commit intoMASILab:masterfrom
Open
Check if required inputs exist in pipeline.sh#8jakepalmer wants to merge 1 commit intoMASILab:masterfrom
jakepalmer wants to merge 1 commit intoMASILab:masterfrom
Conversation
|
@jakepalmer Awesome, thank you! This looks perfect to me but I will leave it up to the bosses @schillkg @hanscol to make final decision/merge when they get a chance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a check for existence of required inputs to
pipeline.shbased on required input in README and assuming directory structure of docker/singularity.Currently, if the b0 input doesn't match exactly
b0.nii.gzthen the pipeline will only fail after working for a while on theT1.nii.gz, with theprepare_input.shscript still indicating theb0.nii.gzinput exists.Discovered this when an upstream process named the b0 input as
b0_tmp.nii.gzrather thanb0.nii.gz. Intended that these checks catch this type of oversight early.Note: I ran dos2unix to test this locally via docker, and unix2dos before commit.
(This is my first PR so I'm open to feedback!)