Skip to content

Solution to #4146 : Adding the option to specify the Microsoft Tenant…#4151

Merged
ildyria merged 2 commits intoLycheeOrg:masterfrom
agademer:agademer/improvement_microsoft_tenant_id
Mar 7, 2026
Merged

Solution to #4146 : Adding the option to specify the Microsoft Tenant…#4151
ildyria merged 2 commits intoLycheeOrg:masterfrom
agademer:agademer/improvement_microsoft_tenant_id

Conversation

@agademer
Copy link
Contributor

@agademer agademer commented Mar 6, 2026

… ID during Azure Authentication via Socialite

Answer to #4146

The source of the solution is given in the discussion.

Tested on a docker fresh install (hot fix of the php file as I don't have a build environment to test)

Again, thanks for the great app !

Antoine

Summary by CodeRabbit

  • New Features
    • Added support for configuring Microsoft Tenant ID in authentication settings, enabling multi-tenant OAuth configurations.

…ft Tenant ID during Azure Authentication via Socialite
@agademer agademer requested a review from a team as a code owner March 6, 2026 10:40
@ildyria ildyria enabled auto-merge (squash) March 6, 2026 13:52
@agademer
Copy link
Contributor Author

agademer commented Mar 6, 2026

@ildyria : I have the impression that the Php style checker want a space after the comma.
'tenant' => env('MICROSOFT_TENANT_ID', 'common'), and not
'tenant' => env('MICROSOFT_TENANT_ID','common'),

I have no idead how to correct that now that the PR is started (I'm somehow new to this PR process).
But I'm eager to learn / help.

Kind regards,
Antoine

@ildyria
Copy link
Member

ildyria commented Mar 6, 2026

I have no idead how to correct that now that the PR is started (I'm somehow new to this PR process).

Super easy. Add the missing space, make a commit on the same branch and push on your side. It will automatically pick it up and update the PR.

auto-merge was automatically disabled March 7, 2026 16:04

Head branch was pushed to by a user without write access

@coderabbitai
Copy link

coderabbitai bot commented Mar 7, 2026

📝 Walkthrough

Walkthrough

Three configuration files receive updates to support Microsoft Tenant ID. The environment variable is added as commented entries in .env.example and docker-compose.yaml, and the corresponding configuration entry is added to config/services.php with a default fallback value.

Changes

Cohort / File(s) Summary
Environment Configuration
.env.example, docker-compose.yaml
Added commented MICROSOFT_TENANT_ID environment variable declarations for documentation and reference purposes.
Service Configuration
config/services.php
Added 'tenant' configuration key to the Microsoft OAuth service array, reading from MICROSOFT_TENANT_ID environment variable with default value 'common'.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A tenant ID hops in line,
Microsoft's config, now so fine!
Environment vars, all set with care,
OAuth flows with tenant flair! 🌟

🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0bea9b18-6ef1-4ac4-9ba3-7c11c496973c

📥 Commits

Reviewing files that changed from the base of the PR and between 3a625ee and 219d743.

📒 Files selected for processing (3)
  • .env.example
  • config/services.php
  • docker-compose.yaml

@ildyria ildyria enabled auto-merge (squash) March 7, 2026 17:36
@ildyria ildyria merged commit c1e0cc9 into LycheeOrg:master Mar 7, 2026
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants