Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components): add navlink component #46

Merged
merged 9 commits into from
Jul 19, 2024
Merged

feat(components): add navlink component #46

merged 9 commits into from
Jul 19, 2024

Conversation

desmondinho
Copy link
Contributor

Description

Add the NavLink component representing a navigation link within the application.
Put the common part for both Link and NavLink components into the base LinkBase class.

Closes #32

What's been done?

Added the component mentioned above with the following abilities:

  • Set the child content
  • Set the href
  • Set the color
  • Set the disabled state
  • Set the URL matching behavior (e.g., prefix, all)

Basically, this component is just a wrapper around the native NavLink component.

Note

The ActiveClass parameter is not exposed in favor of a consistent way of custom CSS classes application. An active data attribute should be used to style the active state of the link.

Checklist

  • My code follows the project's coding style and guidelines.
  • I have included inline docs for my changes, where applicable.
  • I have added, updated or removed tests according to my changes.
  • All tests are passing.
  • There's an open issue for the PR that I am making.

@desmondinho desmondinho added ✨ Type: Enhancement New feature or request 📦 Scope: Components Improvements or additions to components labels Jul 19, 2024
@desmondinho desmondinho added this to the 1.0.0 milestone Jul 19, 2024
@desmondinho desmondinho self-assigned this Jul 19, 2024
@desmondinho desmondinho linked an issue Jul 19, 2024 that may be closed by this pull request
1 task
@desmondinho desmondinho removed this from the 1.0.0 milestone Jul 19, 2024
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.25%. Comparing base (7e58af5) to head (48e8c4f).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #46      +/-   ##
==========================================
+ Coverage   98.22%   98.25%   +0.03%     
==========================================
  Files          52       55       +3     
  Lines        1067     1086      +19     
  Branches      104      107       +3     
==========================================
+ Hits         1048     1067      +19     
  Misses         12       12              
  Partials        7        7              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@desmondinho desmondinho merged commit 65c34cb into main Jul 19, 2024
3 checks passed
@desmondinho desmondinho deleted the feat/navlink branch July 19, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 Scope: Components Improvements or additions to components ✨ Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Add navigation link component
1 participant