-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(components): add navigation bar component #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erence` with the portal-like behavior
…rMenuItem` & `NavbarToggle` components
1 task
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #39 +/- ##
==========================================
- Coverage 98.24% 98.22% -0.02%
==========================================
Files 43 52 +9
Lines 968 1067 +99
Branches 101 104 +3
==========================================
+ Hits 951 1048 +97
Misses 12 12
- Partials 5 7 +2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
📦 Scope: Components
Improvements or additions to components
✨ Type: Enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the navbar component, along with the brand, toggle, menu, menu item, content and item components, to the component library.
Closes #38
What's been done?
Added the components mentioned above with the following abilities:
Navbar: A component representing a navigation bar
Navbar brand: A component representing the brand section of the navigation bar
Navbar content: A component representing the content section of the navigation bar
Navbar item: A component representing a navigation item within the content section
Navbar menu: A component representing a collapsible menu for the navigation bar
NavbarMenuToggle
Navbar menu item: A component representing a navigation item within the menu
Navbar menu toggle: A component representing a button that toggles the menu
Navbar context: A class representing the navigation bar context
Navbar
componentNavbarMenu
componentNavbar slots: A class representing the various slot configurations for the
Navbar
Navbar
, it is the main container.Navbar
component, it contains components such asNavbarBrand
,NavbarContent
,NavbarToggle
and others.NavbarBrand
component.NavbarContent
component.NavbarItem
component.NavbarMenu
component.NavbarMenuItem
component.NavbarMenuToggle
component.NavbarMenuToggle
icon.Checklist