Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components): add switch component #31

Merged
merged 7 commits into from
Jul 6, 2024
Merged

feat(components): add switch component #31

merged 7 commits into from
Jul 6, 2024

Conversation

desmondinho
Copy link
Contributor

Description

Add the switch component to the components library.

Closes #30

What's been done?

Added the switch and the base boolean input components with the following abilities:

Base boolean input

It is a derived class from LumexInputBase<bool> class. It holds a common functionality for all the boolean input components, such as LumexCheckbox and LumexSwitch.

Switch

  • Set custom label content
  • Set custom thumb icon
  • Set start icon
  • Set end icon
  • Set CSS class names for each slot

Checklist

  • My code follows the project's coding style and guidelines.
  • I have included inline docs for my changes, where applicable.
  • I have added, updated or removed tests according to my changes.
  • All tests are passing.
  • There's an open issue for the PR that I am making.

@desmondinho desmondinho added ✨ Type: Enhancement New feature or request 📦 Scope: Components Improvements or additions to components labels Jul 6, 2024
@desmondinho desmondinho self-assigned this Jul 6, 2024
@desmondinho desmondinho linked an issue Jul 6, 2024 that may be closed by this pull request
1 task
Copy link

codecov bot commented Jul 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.23%. Comparing base (e8fb98f) to head (86f38ed).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
+ Coverage   98.19%   98.23%   +0.04%     
==========================================
  Files          40       43       +3     
  Lines         939      962      +23     
  Branches       97      101       +4     
==========================================
+ Hits          922      945      +23     
  Misses         12       12              
  Partials        5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@desmondinho desmondinho merged commit c31e296 into main Jul 6, 2024
3 checks passed
@desmondinho desmondinho deleted the feat/switch branch July 6, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 Scope: Components Improvements or additions to components ✨ Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Add switch component
1 participant