Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components): add checkbox component #21

Merged
merged 11 commits into from
Jun 7, 2024
Merged

feat(components): add checkbox component #21

merged 11 commits into from
Jun 7, 2024

Conversation

desmondinho
Copy link
Contributor

@desmondinho desmondinho commented Jun 7, 2024

Description

Add the checkbox component to the library of components.

Closes #20

What's been done?

Added the checkbox and base input components with the following abilities:

Base input

  • Set the disabled state
  • Set the read-only state
  • Set the theme color (e.g., primary, danger)
  • Set the border radius (e.g., none, medium)
  • Set the size (e.g., small, large)
  • 2-way value binding

Checkbox

  • Set custom label content
  • Set custom check icon
  • Set CSS class names for each slot

Checklist

  • My code follows the project's coding style and guidelines.
  • I have included inline docs for my changes, where applicable.
  • I have added, updated or removed tests according to my changes.
  • All tests are passing.
  • There's an open issue for the PR that I am making.

Additional Notes

@desmondinho desmondinho added ✨ Type: Enhancement New feature or request 📦 Scope: Components Improvements or additions to components labels Jun 7, 2024
@desmondinho desmondinho self-assigned this Jun 7, 2024
@desmondinho desmondinho linked an issue Jun 7, 2024 that may be closed by this pull request
1 task
@desmondinho desmondinho merged commit 8cbc234 into main Jun 7, 2024
1 check passed
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 98.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.11%. Comparing base (f1a6b43) to head (f9251fb).
Report is 2 commits behind head on main.

Files Patch % Lines
src/LumexUI/Components/Bases/LumexInputBase.cs 97.37% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #21      +/-   ##
==========================================
+ Coverage   98.06%   98.11%   +0.05%     
==========================================
  Files          33       37       +4     
  Lines         823      898      +75     
  Branches       78       89      +11     
==========================================
+ Hits          807      881      +74     
  Misses         12       12              
- Partials        4        5       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@desmondinho desmondinho deleted the feat/checkbox branch June 7, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 Scope: Components Improvements or additions to components ✨ Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Add checkbox component
1 participant