Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components): add icon component #19

Merged
merged 4 commits into from
Jun 1, 2024
Merged

feat(components): add icon component #19

merged 4 commits into from
Jun 1, 2024

Conversation

desmondinho
Copy link
Contributor

@desmondinho desmondinho commented Jun 1, 2024

Description

Add the icon component to the library of components.

Closes #18

What's been done?

Added the simple icon component with the following abilities:

  • Set the name (font icon) or SVG path of the icon
  • Set the size
  • Set the viewBox
  • Set the color (e.g., primary, danger)

Checklist

  • My code follows the project's coding style and guidelines.
  • I have included inline docs for my changes, where applicable.
  • I have added, updated or removed tests according to my changes.
  • All tests are passing.
  • There's an open issue for the PR that I am making.

@desmondinho desmondinho added ✨ Type: Enhancement New feature or request 📦 Scope: Components Improvements or additions to components labels Jun 1, 2024
@desmondinho desmondinho self-assigned this Jun 1, 2024
@desmondinho desmondinho linked an issue Jun 1, 2024 that may be closed by this pull request
1 task
Copy link

codecov bot commented Jun 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.06%. Comparing base (1737150) to head (f4dd2bf).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #19      +/-   ##
==========================================
+ Coverage   98.02%   98.06%   +0.04%     
==========================================
  Files          31       33       +2     
  Lines         808      823      +15     
  Branches       76       78       +2     
==========================================
+ Hits          792      807      +15     
  Misses         12       12              
  Partials        4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@desmondinho desmondinho merged commit 9bf0dd2 into main Jun 1, 2024
3 checks passed
@desmondinho desmondinho deleted the feat/icon branch June 1, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 Scope: Components Improvements or additions to components ✨ Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Add icon component
1 participant