fix(pflash): batch automatic FlowKV compression - #612
Merged
Conversation
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 8 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--prefill-compression autorequests through FlowKV without requiring the unrelated disk-cache compression flag--prefill-curvefrom the full context lengthVerification
dflash_serverandtest_server_unitfrom a cleanorigin/mainworktree on RTX 5090OK, 25,097 prompt tokens reduced to 2,313 effective tokens in 5.43 sExisting test failure
The full GPU unit binary reports 359/360. The untouched DS4 test
fractional_route_quota_rounds_over_the_batchalso failed before this patch; the focused PFlash/FlowKV tests pass.