Recognize a class inheriting a generic one as a child of its parent - #3441
Open
RomanSpector wants to merge 2 commits into
Open
Recognize a class inheriting a generic one as a child of its parent#3441RomanSpector wants to merge 2 commits into
RomanSpector wants to merge 2 commits into
Conversation
A parent given with arguments (`---@Class A : B<string>`) is parsed into `doc.type.sign`, which keeps the name one level down. The inheritance walk only looked at plain names, so such a parent was skipped entirely: `A` was not recognized as a child of whatever `B` itself inherits, and passing it where the base type is expected reported a mismatch. The name is now taken from the sign node as well. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A class inheriting a generic one was not recognized as a child of what that generic itself inherits:
A parent given with arguments is parsed into
doc.type.sign, which keeps the name one level down. The inheritance walk invm.isSubTypeonly looked atdoc.extends.name, so such a parent was skipped entirely and the chain broke at that point.The name is now taken from the sign node as well. A test in
param-type-mismatchcovers the case above.