Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(extract-features): properly check if Skew is being used #106

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

Aidosmf
Copy link
Collaborator

@Aidosmf Aidosmf commented Aug 28, 2024

Description

Some tools by default export Transform Skew with a static value 0

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)
  • Minor: New feature (non-breaking change which adds functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • This is something we need to do.

@Aidosmf Aidosmf added the bug Something isn't working label Aug 28, 2024
@Aidosmf Aidosmf requested a review from naaish-adam August 28, 2024 10:18
@Aidosmf Aidosmf self-assigned this Aug 28, 2024
Copy link

changeset-bot bot commented Aug 28, 2024

🦋 Changeset detected

Latest commit: f62e792

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@lottiefiles/relottie-extract-features Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@lottiefiles-bot
Copy link
Collaborator

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/last/dist/index.js 0 B (+100% 🔺) 0 ms (+100% 🔺) 13 ms (+50.01% 🔺) 13 ms
packages/last-builder/dist/index.js 0 B (+100% 🔺) 0 ms (+100% 🔺) 8 ms (-51.52% 🔽) 8 ms
packages/relottie/dist/index.js 21.46 KB (0%) 430 ms (0%) 1.3 s (+188.62% 🔺) 1.7 s
packages/relottie-parse/dist/index.js 10.67 KB (0%) 214 ms (0%) 189 ms (+22.75% 🔺) 402 ms
packages/relottie-stringify/dist/index.js 0 B (+100% 🔺) 0 ms (+100% 🔺) 8 ms (-40.52% 🔽) 8 ms
packages/relottie-extract-features/dist/index.js 5.38 KB (+0.39% 🔺) 108 ms (+0.39% 🔺) 44 ms (+4.03% 🔺) 152 ms
packages/relottie-metadata/dist/index.js 5.07 KB (0%) 102 ms (0%) 64 ms (+62.5% 🔺) 165 ms

Copy link
Collaborator

@naaish-adam naaish-adam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aidosmf Aidosmf merged commit bfbe50b into main Aug 28, 2024
3 checks passed
@Aidosmf Aidosmf deleted the mf/fix-skew-detection branch August 28, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants